Skip to content

Upgrade gophercloud to v0.4.0#486

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jsen-:patch-1
Oct 26, 2019
Merged

Upgrade gophercloud to v0.4.0#486
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jsen-:patch-1

Conversation

@jsen-
Copy link
Contributor

@jsen- jsen- commented Oct 25, 2019

Resolves issue with date parsing in Ocata. See #485 for more details

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #485

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

Resolves issue with date parsing in `Ocata`. See #485 for more details
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jsen-. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and justinsb October 25, 2019 13:52
@sbueringer
Copy link
Member

sbueringer commented Oct 26, 2019

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2019
@sbueringer
Copy link
Member

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsen-, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 29d3113 into kubernetes-sigs:master Oct 26, 2019
@jsen- jsen- deleted the patch-1 branch October 27, 2019 15:38
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Resolves issue with date parsing in `Ocata`. See kubernetes-sigs#485 for more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade gophercloud to v0.4.0

3 participants