use existing networks, fallback to network/subnet defined in cluster …#475
Closed
sbueringer wants to merge 4 commits intokubernetes-sigs:masterfrom
Closed
use existing networks, fallback to network/subnet defined in cluster …#475sbueringer wants to merge 4 commits intokubernetes-sigs:masterfrom
sbueringer wants to merge 4 commits intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
/assign @jichenjc I didn't test it yet myself but I'm on it :) |
k8s-ci-robot
added
the
do-not-merge/hold
Member
Author
|
Okay I tested my existing multi-node setup and I tested it with remove networks filter. Both worked /hold cancel @jichenjc Can you test if you're now able to use loadbalancers by setting the network and subnet fields (filters) in the ClusterSpec? |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
Author
|
Was fixed in #477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the following:
Fixes #428