Closed
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XL
Member
Author
|
/assign @hidekazuna /hold |
k8s-ci-robot
added
the
do-not-merge/hold
prankul88
reviewed
Sep 20, 2019
prankul88
reviewed
Sep 20, 2019
prankul88
reviewed
Sep 23, 2019
Contributor
|
I will merge this after some minor tweaks |
Member
Author
|
I have to reopen this pr. Unfortunately I pushed the branch to the wrong repo :/ |
Member
Author
|
new PR can be found here: #474 @prankul88 I fixed all your findings |
Contributor
|
@sbueringer Great. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final doc pr before v0.2.0.
I tried to shorten the documentation a bit, because to be honest we're not able to keep that much documentation up-to-date. Most of the previous documentation was easily accessible by taking a quick glimpse into the code. Also there will be a lot more documentation from the Cluster API project itself (https://cluster-api.sigs.k8s.io). I will also add a PR in the main repo in the week or so to add the OpenStack provider to the quickstart.
Fixes #380
P.S. I would like to create the release after this PR is merged, but I will open another issue for this.