some minor fix during test on ubuntu#451
Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:masterfrom Aug 26, 2019
Merged
some minor fix during test on ubuntu#451k8s-ci-robot merged 4 commits intokubernetes-sigs:masterfrom
k8s-ci-robot merged 4 commits intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
size/L
Contributor
Contributor
Author
|
@hidekazuna yes, I am fixing a set of minor issues. |
Contributor
|
@jichenjc Thanks, I will try this PR. |
hidekazuna
reviewed
Aug 26, 2019
Contributor
hidekazuna
left a comment
hidekazuna
left a comment
There was a problem hiding this comment.
Could you also update controlPlaneEndpoint: "53.48.112.86:6443" in machines.yaml templates?
Member
|
Sorry didn't saw this pr I'll rebase my new pr to these fixes |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* some minor fix during test on ubuntu * Additional change based on test * cluster.yaml * djust folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: