Skip to content

[v1alpha2 Migration] add v1alpha2 types#445

Closed
sbueringer wants to merge 5 commits intokubernetes-sigs:masterfrom
sbueringer:pr-add-v1alpha2-types
Closed

[v1alpha2 Migration] add v1alpha2 types#445
sbueringer wants to merge 5 commits intokubernetes-sigs:masterfrom
sbueringer:pr-add-v1alpha2-types

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 17, 2019

This PR is the first step via ClusterAPI v1alpha2. It only creates the new v1alpha2 types in the old kubebuilder structure. See #380 (comment) for more details.

This PR doesn't:

  • break any v1alpha1 behavior
  • touch the machine/cluster actuator
  • upgrade to kubebuilder v2

Types have been generated via:

kubebuilder create api --group infrastructure --version v1alpha2 --kind OpenStackCluster
kubebuilder create api --group infrastructure --version v1alpha2 --kind OpenStackMachine

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2019
@sbueringer
Copy link
Member Author

/assign @jichenjc
/assign @hidekazuna

@sbueringer sbueringer changed the title add v1alpha2 types [v1alpha2 Migration] add v1alpha2 types Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbueringer
To complete the pull request process, please assign jichenjc
You can assign the PR to them by writing /assign @jichenjc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jichenjc
Copy link
Contributor

jichenjc commented Aug 18, 2019

to make it easier for mergeing
#447 backport code from master to rlease 0.1
and
#448 add hint on relase0.1 branch

so we can start to merge code into master now...

@sbueringer
Copy link
Member Author

I'm not sure if I should just close this PR. #446 already supersedes it. And I guess its easier to just review the final CRDs.

@jichenjc What do you think?

@jichenjc
Copy link
Contributor

yeah, I agree it will be easier to check only one PR and do local try as well..thanks

@sbueringer
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-add-v1alpha2-types branch October 6, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants