Pr create floating ip on demand#435
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom Aug 19, 2019
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Member
Author
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-create-floating-ip-on-demand
branch
4 times, most recently
from
c3b2646 to
6fb3e5a
Compare
k8s-ci-robot
added
size/M
Member
Author
|
@jichenjc I rebased this PR. Diff looks now friendlier :) Can you take a look? This should allow reusing existing floating ips for the LoadBalancer. |
jichenjc
reviewed
Aug 16, 2019
jichenjc
reviewed
Aug 16, 2019
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
/assign @hidekazuna Can you please take a look? :) |
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-create-floating-ip-on-demand
branch
from
1762e20 to
1d87952
Compare
k8s-ci-robot
added
size/L
jichenjc
reviewed
Aug 16, 2019
sbueringer
force-pushed
the
pr-create-floating-ip-on-demand
branch
from
72ca8c7 to
1d87952
Compare
k8s-ci-robot
added
size/M
Member
Author
|
/hold Waiting until the new v1alpha2 controllers are merged |
k8s-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/hold cancel I think it's safe to merge. I just have to make sure to not loose it in the controllers PR :) |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
prankul88
pushed a commit
to prankul88/cluster-api-provider-openstack
that referenced
this pull request
Sep 5, 2019
* create machine floating ips if they don't already exist * only associate floating ip if it already exists
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* create machine floating ips if they don't already exist * only associate floating ip if it already exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates machine floating ips if they don't exist. Depending on the interpretation fixes #427 :)
What this PR does / why we need it:
Floating IP handling is now consistent. LoadBalancer & machine floating ip's are both created if they don't already exist. If they already exist they are just associated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #427