Create kubeconfig for each cluster in reconcile function#412
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom Jul 29, 2019
Merged
Create kubeconfig for each cluster in reconcile function#412k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/work-in-progress
per issue 413 indicated, we need a masterip in order to create kubeconfig file.
per cluster-api changes, this is needed for provider to create and utilized by cluster-api manager container
k8s-ci-robot
added
size/M
jichenjc
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
reviewed
Jul 29, 2019
| return "", errors.New("MasterIP in cluster spec not set") | ||
| } | ||
| ip = config.MasterIP | ||
| } |
Member
There was a problem hiding this comment.
We have to merge this with this code here:
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/401/files#diff-266c339b51cf18a076cf106526357c53R70-R78
Member
There was a problem hiding this comment.
I guess this would be in the else branch if ManagedAPIServerLoadBalancer is set to false
Contributor
Author
There was a problem hiding this comment.
yes, let's work on that patch first then rebase from there
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
…sigs#412) * Add masterip into clusterproviderspec per issue 413 indicated, we need a masterip in order to create kubeconfig file. * Create secret kubeconfig-<cluster> per cluster-api changes, this is needed for provider to create and utilized by cluster-api manager container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #410
Fixes #413
Special notes for your reviewer:
Release note: