Skip to content

Update kubeadm to 1.15#389

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jichenjc:upgrade_1_15
Jul 13, 2019
Merged

Update kubeadm to 1.15#389
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
jichenjc:upgrade_1_15

Conversation

@jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jul 5, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from chrigl and dims July 5, 2019 16:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2019
@jichenjc jichenjc changed the title Update kubeadm to 1.15 WIP:Update kubeadm to 1.15 Jul 6, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2019
@dims dims removed their request for review July 8, 2019 15:09
@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 9, 2019

kubectl get nodes --kubeconfig kubeconfigNAME STATUS ROLES AGE VERSION
openstack-master-pm4zm.novalocal Ready master 4m56s v1.15.0
openstack-node-qsbnb.novalocal Ready 33s v1.15.0

@jichenjc jichenjc changed the title WIP:Update kubeadm to 1.15 Update kubeadm to 1.15 Jul 9, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@hidekazuna
Copy link
Contributor

Thanks, I tested this works. Could you update machine-deployment.yaml.template as well?

@chrigl
Copy link

chrigl commented Jul 11, 2019

@jichenjc could you also add 1.15 to the table in README.md

@sbueringer
Copy link
Member

kubectl get nodes --kubeconfig kubeconfigNAME STATUS ROLES AGE VERSION
openstack-master-pm4zm.novalocal Ready master 4m56s v1.15.0
openstack-node-qsbnb.novalocal Ready 33s v1.15.0

I can also confirm that it just works with Kubernetes & kubeadm 1.15. It also works on my latest multi-node control plane branch.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2019
@sbueringer
Copy link
Member

sbueringer commented Jul 13, 2019

@jichenjc Okay so only the change in machine-deployment.yaml.template is left until we can get this merged?

@jichenjc
Copy link
Contributor Author

I will update the machine-deployment.yaml.template, forgot to update it :)

@jichenjc
Copy link
Contributor Author

@hidekazuna @sbueringer updated the machine-deployment.template

@sbueringer
Copy link
Member

/lgtm

Thx :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1f34927 into kubernetes-sigs:master Jul 13, 2019
@jichenjc jichenjc mentioned this pull request Jul 16, 2019
pierreprinetti referenced this pull request in shiftstack/cluster-api-provider-openstack Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments