Skip to content

Comments

🐛 codegen: Remove sigs.k8s.io/cluster-api/api/ipam/v1beta1#2884

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.13from
shiftstack:fix-codegen-with-vendoring
Dec 5, 2025
Merged

🐛 codegen: Remove sigs.k8s.io/cluster-api/api/ipam/v1beta1#2884
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.13from
shiftstack:fix-codegen-with-vendoring

Conversation

@stephenfin
Copy link
Contributor

What this PR does / why we need it:

We have not needed this since the bump to CAPI v1beta2 in commit 3489aa8. Its presence breaks the script when vendoring is in use.

This only applies to release-0.13 since the update-codegen.sh script has been removed as part of a larger codegen rework in main.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

(not bug reported: I can open one if needed though)

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

We have not needed this since the bump to CAPI v1beta2 in commit
3489aa8. Its presence breaks the script
when vendoring is in use.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 7c93387
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6932de43e073660007f13acb
😎 Deploy Preview https://deploy-preview-2884--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
@EmilienM
Copy link
Contributor

EmilienM commented Dec 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@EmilienM
Copy link
Contributor

EmilienM commented Dec 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stephenfin
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0cc25bf into kubernetes-sigs:release-0.13 Dec 5, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Dec 5, 2025
@stephenfin stephenfin deleted the fix-codegen-with-vendoring branch December 5, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants