🐛 Don't set OSMachine Ready until all config is complete #2478
+45
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/S
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mdbooth
force-pushed
the
machine-set-ready-last
branch
from
0e09564 to
8e1db6f
Compare
k8s-ci-robot
added
size/M
Contributor
|
/approve |
k8s-ci-robot
added
the
approved
mdbooth
force-pushed
the
machine-set-ready-last
branch
from
8e1db6f to
1f271ed
Compare
EmilienM
force-pushed
the
machine-set-ready-last
branch
from
1f271ed to
4e9ae8f
Compare
mdbooth
force-pushed
the
machine-set-ready-last
branch
from
4e9ae8f to
a75e0e9
Compare
With this change, an OpenStackMachine will not be marked Ready until it has been completely initialised, including setting its Addresses and adding it to the APIServer loadbalancer if required. Also fix a missing early return when the instance has been unexpectedly deleted.
mdbooth
force-pushed
the
machine-set-ready-last
branch
from
a75e0e9 to
cd1066c
Compare
EmilienM
approved these changes
Mar 14, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
/cherry-pick release-0.12 |
|
@EmilienM: new pull request created: #2480 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/retitle 🐛 Don't set OSMachine Ready until all config is complete |
k8s-ci-robot
changed the title
This was referenced Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, an OpenStackMachine will not be marked Ready until it has been completely initialised, including setting its Addresses and adding it to the APIServer loadbalancer if required.
Also fix a missing early return when the instance has been unexpectedly deleted.
/hold