🐛 Stop printing InstanceState for OpenStackMachine#2402
🐛 Stop printing InstanceState for OpenStackMachine#2402k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
`InstanceState` was copied to the `OpenStackServer` API and the `OpenStackMachine` controller doesn't care about this field anymore. The field still exists for backward compatibility but it was decided long time ago (when we worked on the `OpenStackServer` API) that it wouldn't be populated anymore. We missed to stop printing this field when listing the `OpenStackMachines`. Also, we now document that the field is not populated anymore. This was also a miss.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cherry-pick release-0.12 |
|
@EmilienM: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lentzi90
left a comment
lentzi90
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for fixing!
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@EmilienM: new pull request created: #2406 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What this PR does / why we need it:
InstanceStatewas copied to theOpenStackServerAPI and theOpenStackMachinecontroller doesn't care about this field anymore.The field still exists for backward compatibility but it was decided
long time ago (when we worked on the
OpenStackServerAPI) that itwouldn't be populated anymore.
We missed to stop printing this field when listing the
OpenStackMachines.Also, we now document that the field is not populated anymore. This was
also a miss.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2400