Skip to content

🌱 Update cloudbuild image#2365

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Nordix:lentzi90/fix-postsubmit
Jan 14, 2025
Merged

🌱 Update cloudbuild image#2365
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Nordix:lentzi90/fix-postsubmit

Conversation

@lentzi90
Copy link
Contributor

What this PR does / why we need it:

The image used in the postsubmit job that builds staging images was outdated. It had an image with go1.18 and could not build the image.

The postsubmit is defined here: https://github.com/kubernetes/test-infra/blob/db5b76499f19afb56681629ec1e1b9514e1ecf24/config/jobs/image-pushing/k8s-staging-cluster-api.yaml#L244

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2297

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

The image used in the postsubmit job that builds staging images was outdated.
It had an image with go1.18 and could not build the image.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@lentzi90
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-openstack-build
/test pull-cluster-api-provider-openstack-e2e-test
/test pull-cluster-api-provider-openstack-test

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-openstack-conformance-test
/test pull-cluster-api-provider-openstack-e2e-full-test

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-openstack-build
pull-cluster-api-provider-openstack-e2e-test
pull-cluster-api-provider-openstack-test
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 1ca9c47
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/678653e15b54b7000877e275
😎 Deploy Preview https://deploy-preview-2365--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lentzi90
Copy link
Contributor Author

@mdbooth is there a way to trigger the postsubmit job on a PR? It seems prow does not expose it here

@mdbooth
Copy link
Contributor

mdbooth commented Jan 14, 2025

I don't know, I'm afraid.

@lentzi90
Copy link
Contributor Author

Oh well, we cannot break something that is already broken at least 🤷
https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/post-cluster-api-provider-openstack-push-images

@EmilienM
Copy link
Contributor

/hold cancel
/lgtm
/approve

and pray for the best

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@EmilienM
Copy link
Contributor

/cherry-pick release-0.11 release-0.10

@k8s-infra-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.11 release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 05774bc into kubernetes-sigs:main Jan 14, 2025
3 checks passed
@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2366

Details

In response to this:

/cherry-pick release-0.11 release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Post merge job failing beause of invalid go version

5 participants