🐛 Ensure that existing ports also have correct tags and trunks#2356
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Don't merge this yet. We are validating that it does solve the issue internally. |
|
There was a failure to cleanup docker in docker. All tests passed though. |
|
how bad was the merge conflict? I'm curious. Mainly for future backports around this code. |
|
Not that bad actually. There were a couple of small conflicts due to the introduction of OpenStackServer. Most of it was just that the files didn't exist though. The only thing needed then was to find where the relevant code was before the OpenStackServer existed. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@lentzi90 what about this one? is it still under testing? |
|
Yes. It was important to fix but apparently not important enough to test quickly... |
lentzi90
force-pushed
the
lentzi90/ensure-ports-tags-release-0.10
branch
from
722f27d to
45f6b72
Compare
k8s-ci-robot
removed
the
lgtm
|
Now we have confirmation that it is working. I had missed one thing when doing the backport so had to push again. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Weird... all tests passed locally. Checking |
If port creation fails in the middle, and cleanup also fails, then we may end up with ports with missing tags or trunks. This could happen when hitting rate-limits for example or if there is a network outage. This commit addresses the issue by going through existing ports and ensuring that they have correct tags and trunks. Co-authored-by: Huy Mai <huy.mai@est.tech> Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/ensure-ports-tags-release-0.10
branch
from
45f6b72 to
68e7b13
Compare
|
/cc @EmilienM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
merged commit fcf6f1f
into
kubernetes-sigs:release-0.10
3 participants
What this PR does / why we need it:
If port creation fails in the middle, and cleanup also fails, then we may end up with ports with missing tags or trunks. This could happen when hitting rate-limits for example or if there is a network outage. This commit addresses the issue by going through existing ports and ensuring that they have correct tags and trunks.
This is a manual backport of #2256
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold