Skip to content

🌱 Temporarily disable deep image inspection in DevStack#2303

Closed
stephenfin wants to merge 1 commit intokubernetes-sigs:mainfrom
shiftstack:disable-deep-image-inspection-in-ci
Closed

🌱 Temporarily disable deep image inspection in DevStack#2303
stephenfin wants to merge 1 commit intokubernetes-sigs:mainfrom
shiftstack:disable-deep-image-inspection-in-ci

Conversation

@stephenfin
Copy link
Contributor

What this PR does / why we need it:

Disable the deep image inspection recently added to Nova while we investigate the issues with flatcar images further [1].

[1] https://bugs.launchpad.net/nova/+bug/2091114

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

(none)

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

While we investigate the issues with flatcar images further [1].

[1] https://bugs.launchpad.net/nova/+bug/2091114

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mdbooth for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@netlify
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit d54fb90
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6751dd73ae26dc0008fc17fc
😎 Deploy Preview https://deploy-preview-2303--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth
Copy link
Contributor

mdbooth commented Dec 5, 2024

Assuming the tests pass:
/lgtm

@lentzi90 or @EmilienM want to take a look? I prefer this to disabling the Flatcar tests.

I see one of 2 potential outcomes here:

  • OpenStack decides not to support Flatcar's partition table, in which case we fix the Flatcar images
  • OpenStack fixes the regression and we remove the workaround

Either way it's not directly relevant to CAPO and I'd prefer not to lose the Flatcar coverage in the meantime.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@lentzi90
Copy link
Contributor

lentzi90 commented Dec 5, 2024

/hold
We are mixing things up I think. We do not see the issue with the flatcar image on main as far as I know. It only happens when we bump devstack to 2024.2. So this PR is not really testing that

@EmilienM
Copy link
Contributor

EmilienM commented Dec 6, 2024

This was added to #2302
/close
re-open if I missed something
thanks for the help with the debug

@k8s-ci-robot
Copy link
Contributor

@EmilienM: Closed this PR.

Details

In response to this:

This was added to #2302
/close
re-open if I missed something
thanks for the help with the debug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants