🌱 Simplify codegen usage and stop deleting generated clientsets#2206
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Oct 29, 2024
Merged
🌱 Simplify codegen usage and stop deleting generated clientsets#2206k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdbooth
changed the title
We no longer need a temporary 'core' symlink for generating clients for a single group. We no longer need to delete the generated clientsets, as we're now using the same k8s version in the package as the generator, which is the intended usage.
This module was a workaround because it required newer k8s deps than the main module. This is no longer the case, so it's no longer required.
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
Contributor
|
/approve |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the way we execute codegen, removing the hacks required prior to code-generate v0.31.1.
The codegen module is no longer required. codegen is now just 2 files:
A side-effect of this change is that we no longer delete the clientset generated by codegen. This makes it easier to use the APIs as a library without the controller-runtime client. This is the source of almost all the added code.
This PR is based on the bump to v1.31.1, so we need to merge that first.
/hold