🌱 E2E: Add subports to trunked port to test subports deletion#2141
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @mquhuy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
6 times, most recently
from
14e6083 to
428bf24
Compare
|
/test pull-cluster-api-provider-openstack-e2e-test |
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
from
428bf24 to
6bb273f
Compare
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
from
6bb273f to
2834de0
Compare
k8s-ci-robot
added
size/M
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
7 times, most recently
from
601d45b to
941da20
Compare
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
2 times, most recently
from
85692aa to
9cff7f0
Compare
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
3 times, most recently
from
209fbdb to
be2a1a3
Compare
test/e2e/suites/e2e/e2e_test.go
Outdated
| ).Should(BeTrue()) | ||
|
|
||
| // Wait here for some time, to make sure the reconciler fully cleans everything | ||
| time.Sleep(100 * time.Second) |
There was a problem hiding this comment.
not sure whether we can do like
sleep 5,10,20,50 etc to make the sleep time smaller?
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
3 times, most recently
from
4318b51 to
a4ca5fa
Compare
mquhuy
force-pushed
the
mquhuy/ensure-trunkport-deletion-e2e-test
branch
13 times, most recently
from
a7b5af1 to
e11cfae
Compare
Signed-off-by: Huy Mai <huy.mai@est.tech>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
6 participants
This is a continuation of #2081. The idea is to have subports added to trunked port, so that we could verify that subports are deleted with the trunk.