✨ New CRD + controller for OpenStackServer (v1alpha1) by EmilienM · Pull Request #2067 · kubernetes-sigs/cluster-api-provider-openstack

EmilienM · 2024-05-07T18:53:10Z

What this PR does / why we need it:

A new CRD and controller which will manage the OpenStack servers in the cluster.

#2020
#2021

TODOs:

Future work that can happen outside this PR:

Stop populating server related status fields for both OpenStackCluster and OpenStackMachine objects, since they now live in OpenStackServer. The fields will be removed for a potential v1.
Optimize SetupWithManager when watching for OpenStackServer, since we are only interested in certain state transition: when the server is deleted, and when the server is ready. For that we probably want to write Predicate functions.

netlify · 2024-05-07T18:53:26Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`fb3779c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66990e7fdf2bc80008aef505
😎 Deploy Preview	https://deploy-preview-2067--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

api/v1alpha1/openstackserver_types.go

controllers/openstackcluster_controller_test.go

EmilienM · 2024-05-31T15:18:13Z

controllers/openstackmachine_controller_test.go

 		wantRemoveFinalizer bool
 		clusterNotReady     bool
 	}{
-		{


I translated all these tests into openstackserver_controller.

api/v1alpha1/openstackserver_types.go

controllers/openstackserver_controller.go

pkg/cloud/services/compute/instance.go

pkg/cloud/services/networking/port.go

mdbooth · 2024-05-31T19:57:00Z

pkg/webhooks/openstackserver_webhook.go

Is there any validation we can't do with CEL? If not, lets delete this.

the only validation we make here is to ensure immutability. I don't know enough CEL to know if it can check that. However I'll investigate. However I'm not sure if CEL recognize TopologyDryRunAnnotation (link).
I checked other providers and they do that via the webhook.

mdbooth · 2024-05-31T19:57:54Z

pkg/webhooks/openstackserver_webhook_test.go

Lets put all of these in the apivalidations suite instead. That way they will still work when we implement them with CEL.

I'll put that into a separate commit for now as I'm not sure whether we want to keep the same validations in OpenStackMachine (?).

docs/book/src/development/development.md

controllers/openstackmachine_controller.go

controllers/openstackcluster_controller.go

EmilienM · 2024-06-11T19:54:08Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

e2e jobs passed, I want to see if they pass again a few times to ensure I didn't miss any race.

EmilienM · 2024-06-11T22:56:47Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-06-11T22:58:55Z

Two successful CI jobs in a row. Let's try a third and stop the rechecks, letting others to review.

EmilienM · 2024-06-24T17:10:09Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-06-24T17:22:11Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-07-02T13:09:44Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

mdbooth

I've looked through OS Server and OS Machine.

OS Server looks fine except for the unused IPAM field in the spec. I think there are a few things to address in OS Machine.

2 high level things to consider:

Should OS Server support IPAM?
Should OS Machine pass fully resolved resources to OS Server?

My personal take on these is:

OS Server should support IPAM. i.e. Leave FloatingIPPoolRef in OS Server spec and add support for it. Remove that support from OS Machine and instead just copy the field from OS Machine spec to OS Server spec.

OS Machine should not fully resolve resources, otherwise we're just duplicating this behaviour between OS Server and OS Machine. i.e. Remove everything from OS Machine that populates or reads resolved or adopted resources.

controllers/openstackserver_controller.go

api/v1alpha1/openstackserver_types.go

controllers/openstackmachine_controller.go

pkg/cloud/services/compute/referenced_resources.go

EmilienM · 2024-07-02T19:27:53Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-07-03T14:00:32Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-07-03T19:24:19Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-07-03T19:31:44Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test

EmilienM · 2024-07-17T12:17:02Z

Just a (clean) rebase on main.

controllers/openstackmachine_controller.go

EmilienM · 2024-07-18T12:46:50Z

/test pull-cluster-api-provider-openstack-e2e-full-test pull-cluster-api-provider-openstack-e2e-test
for sanity, this is ready to merge

mdbooth · 2024-07-18T14:19:46Z

/lgtm
/approve

Let's do this!

k8s-ci-robot · 2024-07-18T14:19:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from dulek and lentzi90 May 7, 2024 18:53

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2024

EmilienM force-pushed the OpenStackServer branch 2 times, most recently from 721f487 to 8c090fe Compare May 8, 2024 12:27

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2024

EmilienM force-pushed the OpenStackServer branch 2 times, most recently from ccbf0b6 to f081701 Compare May 8, 2024 20:44

k8s-ci-robot requested review from mdbooth and removed request for dulek May 8, 2024 20:44

EmilienM force-pushed the OpenStackServer branch 5 times, most recently from b80f256 to c608240 Compare May 9, 2024 20:11

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2024

EmilienM force-pushed the OpenStackServer branch 3 times, most recently from b5c3f50 to cd77e8a Compare May 15, 2024 17:01

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 15, 2024

EmilienM mentioned this pull request May 15, 2024

Errors returned by GetInstanceStatusByName should be handled in machine controller. #2085

Closed

EmilienM force-pushed the OpenStackServer branch 2 times, most recently from 18a83a6 to 0354264 Compare May 15, 2024 19:36

EmilienM commented May 30, 2024

View reviewed changes

api/v1alpha1/openstackserver_types.go Show resolved Hide resolved

EmilienM force-pushed the OpenStackServer branch 3 times, most recently from 9f8ea24 to 2356928 Compare May 30, 2024 19:33

EmilienM commented May 31, 2024

View reviewed changes

controllers/openstackcluster_controller_test.go Show resolved Hide resolved

EmilienM commented May 31, 2024

View reviewed changes

mdbooth reviewed May 31, 2024

View reviewed changes

EmilienM mentioned this pull request Jun 3, 2024

e2e: cloud-config secret can be removed before CAPO/CAPI resources being deleted #2110

Closed

MaysaMacedo reviewed Jun 4, 2024

View reviewed changes

docs/book/src/development/development.md Outdated Show resolved Hide resolved

MaysaMacedo reviewed Jun 4, 2024

View reviewed changes

controllers/openstackmachine_controller.go Outdated Show resolved Hide resolved

MaysaMacedo reviewed Jun 4, 2024

View reviewed changes

controllers/openstackmachine_controller.go Outdated Show resolved Hide resolved

EmilienM commented Jun 6, 2024

View reviewed changes

controllers/openstackcluster_controller.go Outdated Show resolved Hide resolved

mdbooth suggested changes Jul 2, 2024

View reviewed changes

pierreprinetti reviewed Jul 2, 2024

View reviewed changes

pkg/cloud/services/compute/referenced_resources.go Outdated Show resolved Hide resolved

mdbooth reviewed Jul 18, 2024

View reviewed changes

controllers/openstackmachine_controller.go Outdated Show resolved Hide resolved

controllers/openstackmachine_controller.go Show resolved Hide resolved

First iteration of OpenStackServer CRD + controller

fb3779c

Conversation

EmilienM commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

Uh oh!

Uh oh!

EmilienM May 31, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdbooth May 31, 2024

Choose a reason for hiding this comment

Uh oh!

EmilienM Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdbooth May 31, 2024

Choose a reason for hiding this comment

Uh oh!

EmilienM Jun 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EmilienM commented Jun 11, 2024

Uh oh!

EmilienM commented Jun 11, 2024

Uh oh!

EmilienM commented Jun 11, 2024

Uh oh!

EmilienM commented Jun 24, 2024

Uh oh!

EmilienM commented Jun 24, 2024

Uh oh!

EmilienM commented Jul 2, 2024

Uh oh!

mdbooth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EmilienM commented Jul 2, 2024

Uh oh!

EmilienM commented Jul 3, 2024

Uh oh!

EmilienM commented Jul 3, 2024

Uh oh!

EmilienM commented Jul 3, 2024

Uh oh!

EmilienM commented Jul 17, 2024

Uh oh!

Uh oh!

Uh oh!

EmilienM commented Jul 18, 2024

Uh oh!

mdbooth commented Jul 18, 2024

Uh oh!

k8s-ci-robot commented Jul 18, 2024

Uh oh!

Reviewers

EmilienM commented May 7, 2024 •

edited

Loading

netlify bot commented May 7, 2024 •

edited

Loading

EmilienM Jun 3, 2024 •

edited

Loading