⚠️ Convert ServerMetadata from a map to a list by mdbooth · Pull Request #1828 · kubernetes-sigs/cluster-api-provider-openstack

mdbooth · 2024-01-16T16:04:14Z

While we're changing it, we also add validation that keys and values don't exceed 255 characters.

TODO:

Docs

/hold

netlify · 2024-01-16T16:04:20Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`dfb963d`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ba7d1695c1bf0008ac9229
😎 Deploy Preview	https://deploy-preview-1828--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot · 2024-01-16T16:04:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dulek · 2024-01-16T18:13:11Z

config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml

+                        type: array
+                        x-kubernetes-list-map-keys:
+                        - key
+                        x-kubernetes-list-type: map


Will this have more consequences, like e.g. not allowing some characters because K8s doesn't allow them, but OpenStack does?

I don't think there are any constraints on map keys. The documentation only says:

The key fields must be scalars.

They don't have the same constraints as names.

jichenjc · 2024-01-17T08:15:27Z

api/v1alpha8/openstackmachine_types.go

+	// Value is the server metadata value
+	// kubebuilder:validation:MaxLength:=255
+	Value string `json:"value"`
+}


I think we may have other K/V settings , maybe something like Metadata then others reuse it?

This lead me down an interesting rabbit hole which lead here: https://kubernetes.slack.com/archives/C05G4NJ6P6X/p1705486348670669

cc @lentzi90

I don't think so. The only other similar use I found was ValueSpecs, and the above rabbit hole lead me to believe we might want to remove that.

This struct has a 255 character limit on keys and values, which would likely not apply elsewhere.

If we did find another user for it, we could always DRY it later, as struct names don't form part of the API.

For now I think this is ok.

ok, just check in case as I think metadata KV is widely used , but I agree 255 might be a thing not widely used

mdbooth · 2024-01-17T09:16:07Z

/hold for docs

EmilienM · 2024-01-18T18:16:10Z

/hold cancel
doc was pushed.

I'll ask another reviewer to check it before lgtm.

MaysaMacedo

/lgtm

Nice work, Matt

EmilienM · 2024-01-18T21:23:09Z

It's failing on conversion now, Matt changed something with fuzzer, it'll need adjustment. I'll have a look tomorrow.

EmilienM · 2024-01-18T21:23:17Z

/hold

While we're changing it, we also add validation that keys and values don't exceed 255 characters.

EmilienM · 2024-01-31T18:11:32Z

/lgtm
/hold cancel

EmilienM · 2024-01-31T18:12:00Z

Thanks Matt for fixing conversion.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2024

k8s-ci-robot requested review from jichenjc and lentzi90 January 16, 2024 16:04

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2024

mdbooth force-pushed the server-metadata branch from 2f85d39 to f19e3df Compare January 16, 2024 16:23

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2024

dulek reviewed Jan 16, 2024

View reviewed changes

jichenjc reviewed Jan 17, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024

EmilienM force-pushed the server-metadata branch from f19e3df to 9cf43ed Compare January 18, 2024 18:15

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024

MaysaMacedo reviewed Jan 18, 2024

View reviewed changes

k8s-ci-robot assigned MaysaMacedo Jan 18, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024

EmilienM force-pushed the server-metadata branch from 9cf43ed to 980b91b Compare January 18, 2024 21:22

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024

Convert ServerMetadata from a map to a list

dfb963d

While we're changing it, we also add validation that keys and values don't exceed 255 characters.

mdbooth force-pushed the server-metadata branch from 980b91b to dfb963d Compare January 31, 2024 17:02

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024

k8s-ci-robot assigned EmilienM Jan 31, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024

k8s-ci-robot merged commit a80cdd2 into kubernetes-sigs:main Jan 31, 2024

mdbooth deleted the server-metadata branch February 2, 2024 09:23

Conversation

mdbooth commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

k8s-ci-robot commented Jan 16, 2024

Uh oh!

dulek Jan 16, 2024

Choose a reason for hiding this comment

Uh oh!

mdbooth Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jichenjc Jan 17, 2024

Choose a reason for hiding this comment

Uh oh!

mdbooth Jan 17, 2024

Choose a reason for hiding this comment

Uh oh!

jichenjc Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdbooth commented Jan 17, 2024

Uh oh!

EmilienM commented Jan 18, 2024

Uh oh!

MaysaMacedo left a comment

Choose a reason for hiding this comment

Uh oh!

EmilienM commented Jan 18, 2024

Uh oh!

EmilienM commented Jan 18, 2024

Uh oh!

EmilienM commented Jan 31, 2024

Uh oh!

EmilienM commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mdbooth commented Jan 16, 2024 •

edited

Loading

netlify bot commented Jan 16, 2024 •

edited

Loading

mdbooth Jan 17, 2024 •

edited

Loading

jichenjc Jan 19, 2024 •

edited

Loading