-
Notifications
You must be signed in to change notification settings - Fork 287
fix: fix typo of worker rules and controller rules #1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@mdbooth can you help review this? Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, mnaser The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/hold cancel /cherry-pick v0.7 |
|
@jichenjc: once the present PR merges, I will cherry-pick it on top of v0.7 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jichenjc: cannot checkout DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.7 |
|
@jichenjc: new pull request created: #1494 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Sounds great! When can we expect a release? I was hoping for a quick 0.7.1? |
I think 0.7.1 is on the way .... |
EDIT: Sorrey, typo 😅 |
Since 0.7.1 is released but doesn't contain this fix as far as I can see, is there a timeline for 0.7.2? |
|
I guess we can start with back porting it to the release branch. Then it will at least get included in the next patch. /cherry-pick release-0.7 |
|
@lentzi90: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api-provider-openstack#release-0.7 from head k8s-infra-cherrypick-robot:cherry-pick-1492-to-release-0.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-0.7 and k8s-infra-cherrypick-robot:cherry-pick-1492-to-release-0.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Ow sorry, it was already back-ported. Just not in the release. Then we wait I guess 🙂 |
|
#1494 has been backported |
What this PR does / why we need it:
Fixes: #1475
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold