📖 Add documentation about --ca-cert flag#1467
📖 Add documentation about --ca-cert flag#1467k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @alexandrevilain. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
Thanks! There's a nit if you'd like to address it, but I wouldn't hold it up for that.
| ```bash | ||
| kubectl patch deployment capo-controller-manager -n capo-system \ | ||
| --type='json' \ | ||
| -p='[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value": "--ca-certs=/etc/ssl/certs/ca-certificates.crt"}]' | ||
| ``` |
There was a problem hiding this comment.
Nice! I wonder if there's a good way to integrate this into our existing templates to make this simpler 🤔
There was a problem hiding this comment.
That would be nice! As far as I know we can't do conditionals in templates ?
There was a problem hiding this comment.
Yeah, I can't think of a way to do it off the top of my head.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandrevilain, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
alexandrevilain
force-pushed
the
doc/ca-certificates
branch
from
ac98e70 to
a5f7704
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/retest |
3 participants
What this PR does / why we need it:
This PR is a follow up for: #1440
It adds the documentation about the
--ca-certflag added in this PR.Which issue(s) this PR fixes *
Fixes: #1439
Special notes for your reviewer:
TODOs:
/hold