✨ Add Tags to API-Loadbalancer resources

[qeqar]

What this PR does / why we need it:

Add Tags to loadbalancer struct
Add Tags to the

• loadbalancer
• pool
• listener
• member

NOT for the Monitor object, Openstack supports Tags, but the Gohpercloud is not (looked also into newest released version v1.1.1)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1455

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	4791547
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63d3c3308381280009d7c9fc
😎 Deploy Preview	https://deploy-preview-1457--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

Hi @qeqar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qeqar]

Ok, wanted to push early!

And get some feedback:
I cannot find any test that tests the api loadbalancer explicitly. Did i miss it, or are there any testcases i can extent for the new tag feature.

Monitors supporting tags, but gophercloud not see here:https://pkg.go.dev/github.com/gophercloud/gophercloud@v1.1.1/openstack/loadbalancer/v2/monitors#CreateOpts

Is their a need to make a feature request to them too?

Now i need to get my local dev stack ready to at least see if it works :-)

cc: @mdbooth

[mdbooth]

/ok-to-test

[lentzi90]

The code looks fine to me. Do I understand correctly that the point of this is to set the same tags that are specified in openstackcluster.spec.tags on the loadbalancer objects?

Edit: Please squash the commits when you feel ready

[qeqar]

OK squashed and updated the PR.

and yes wanted to add the same Tags as openstackcluster.
They are already used in all other resources.

[lentzi90]

/lgtm

I will trigger the e2e-full test since this is changing the API and that could affect clusterctl upgrade.

/test pull-cluster-api-provider-openstack-e2e-full-test

[jichenjc]

/approve

still hold for folks to take a quick look

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, qeqar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

/hold cancel

no other comments, assume good to go :)