update test from yoga to zed in devstack by jichenjc · Pull Request #1398 · kubernetes-sigs/cluster-api-provider-openstack

jichenjc · 2022-11-25T01:05:51Z

What this PR does / why we need it:

use latest devstack

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

netlify · 2022-11-25T01:05:55Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`9da2cfc`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63982e6433d2bc000898dc13
😎 Deploy Preview	https://deploy-preview-1398--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2022-11-25T01:05:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mnaser · 2022-11-25T18:45:19Z

hack/ci/create_devstack.sh

 #
 # Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
+# may not use this file except in compliance with the License.


I think the CI got upset that you dropped this

I submit this PR before I drink my first tea that day~ :)

will update ：）

jichenjc · 2022-12-06T02:28:51Z

/test pull-cluster-api-provider-openstack-e2e-test

tobiasgiese · 2022-12-06T06:31:34Z

@jichenjc I think your tests will be green after #1408 is merged.
Btw, you probably want to create a new amphora image with the update to zed. Or simply mirror it as described by @mnaser here #1407 (comment)

jichenjc · 2022-12-06T06:33:12Z

no, my problem is devstack encounter issue after switch to zed, I am comparing logs between CPO an CAPO
as CPO already moved to zed and it works fine...

tobiasgiese · 2022-12-06T06:36:13Z

no, my problem is devstack encounter issue after switch to zed, I am comparing logs between CPO an CAPO as CPO already moved to zed and it works fine...

Sure, you're right. It was just because another PR was also failing because of the outdated ubuntu image :)

jichenjc · 2022-12-13T05:55:27Z

/test pull-cluster-api-provider-openstack-e2e-test

jichenjc · 2023-02-18T09:50:35Z

/test pull-cluster-api-provider-openstack-e2e-test

jichenjc · 2023-02-22T00:58:24Z

no idea why this happen, continue to check

Feb 18 10:14:10 capo-e2e-controller neutron-server[133808]: �[00;36mINFO neutron.wsgi [�[00;36m-�[00;36m] �[01;35m�[00;36m10.0.3.15 "GET /networking/v2.0/extensions HTTP/1.1" status: 404 len: 195 time: 0.0027072�[00m�[00m

k8s-ci-robot · 2023-03-04T05:36:29Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-03-27T14:57:26Z

@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-e2e-test	`9da2cfc`	link	true	`/test pull-cluster-api-provider-openstack-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2023-06-25T15:00:00Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mnaser

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/hack/ci/cloud-init/controller.yaml.tpl#L38-L40

is there any reason we're adding those explicit services like trunk etc?

lentzi90 · 2023-06-27T05:02:14Z

I don't know all the details, but regarding trunk I think it is because we have at least one test that makes use of it.

cluster-api-provider-openstack/test/e2e/suites/e2e/e2e_test.go

Lines 277 to 282 in 864f0d8

    
           // assert trunked port is created. 
        
           Eventually(func() int { 
        
           	plist, err = shared.DumpOpenStackPorts(e2eCtx, ports.ListOpts{Description: "trunked", Tags: testTag}) 
        
           	Expect(err).To(BeNil()) 
        
           	return len(plist) 
        
           }, e2eCtx.E2EConfig.GetIntervals(specName, "wait-worker-nodes")...).Should(Equal(1))

dulek · 2023-06-28T13:59:26Z

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/hack/ci/cloud-init/controller.yaml.tpl#L38-L40

is there any reason we're adding those explicit services like trunk etc?

This is how you enable neutron extensions in general.

jichenjc · 2023-06-29T02:58:48Z

This is how you enable neutron extensions in general.

right, I have no idea why it's failing , no time to dig into detail though..

dulek · 2023-06-29T10:50:11Z

This is how you enable neutron extensions in general.

right, I have no idea why it's failing , no time to dig into detail though..

Sounds like a job for me, I'll check.

dulek · 2023-06-29T11:00:30Z

I've created #1598 to be able to play with this.

mdbooth · 2023-10-10T13:02:46Z

Closing in favour of #1598, which I may also close.

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022

k8s-ci-robot requested review from seanschneeweiss and tobiasgiese November 25, 2022 01:05

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022

mnaser suggested changes Nov 25, 2022

View reviewed changes

jichenjc force-pushed the update_openstack branch from f1e4055 to e738033 Compare November 26, 2022 07:03

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2022

jichenjc force-pushed the update_openstack branch 4 times, most recently from d3d64af to 926523a Compare November 28, 2022 07:19

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2022

jichenjc force-pushed the update_openstack branch 3 times, most recently from d059bfe to 9c435ef Compare November 29, 2022 02:31

jichenjc force-pushed the update_openstack branch from 9c435ef to 358aa4c Compare December 13, 2022 07:07

update test from yoga to zed in devstack

9da2cfc

jichenjc force-pushed the update_openstack branch from 358aa4c to 9da2cfc Compare December 13, 2022 07:48

jichenjc mentioned this pull request Feb 22, 2023

switch to OVN of dev test env? #1487

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2023

mnaser suggested changes Jun 26, 2023

View reviewed changes

mdbooth closed this Oct 10, 2023

Conversation

jichenjc commented Nov 25, 2022

Uh oh!

netlify bot commented Nov 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

k8s-ci-robot commented Nov 25, 2022

Uh oh!

mnaser Nov 25, 2022

Choose a reason for hiding this comment

Uh oh!

jichenjc Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jichenjc commented Dec 6, 2022

Uh oh!

tobiasgiese commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jichenjc commented Dec 6, 2022

Uh oh!

tobiasgiese commented Dec 6, 2022

Uh oh!

jichenjc commented Dec 13, 2022

Uh oh!

jichenjc commented Feb 18, 2023

Uh oh!

jichenjc commented Feb 22, 2023

Uh oh!

k8s-ci-robot commented Mar 4, 2023

Uh oh!

k8s-ci-robot commented Mar 27, 2023

Uh oh!

k8s-triage-robot commented Jun 25, 2023

Uh oh!

mnaser left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 commented Jun 27, 2023

Uh oh!

dulek commented Jun 28, 2023

Uh oh!

jichenjc commented Jun 29, 2023

Uh oh!

dulek commented Jun 29, 2023

Uh oh!

dulek commented Jun 29, 2023

Uh oh!

mdbooth commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

netlify bot commented Nov 25, 2022 •

edited

Loading

jichenjc Nov 26, 2022 •

edited

Loading

tobiasgiese commented Dec 6, 2022 •

edited

Loading