📖 Document CRD changes from v1alpha4 to v1alpha5#1216
📖 Document CRD changes from v1alpha4 to v1alpha5#1216k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom apricote:book-crd-changes
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest unrelated to PR |
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
thanks for updating this, can you help to include |
|
@apricote some text for the network changes When using Ports it is now possible to specify network and subnet by filter instead of just ID. As a consequence, the relevant ID fields are now moved into the new filter specifications: ports:
- networkId: d-e-a-d
fixedIPs:
- subnetId: b-e-e-fbecomes: ports:
- network:
id: d-e-a-d
fixedIPs:
subnet:
id: b-e-e-fNetworks are now deprecated. With one exception, all functionality of Networks is now available for Ports. Consequently, Networks will be removed from the API in a future release. The ability of a Network to add multiple ports with a single directive will not be added to Ports. When moving to Ports, all ports must be added explicitly. Specifically, when evaluating the network or subnet filter of a Network, if there are multiple matches we will add all of these to the server. By contrast we raise an error if the network or subnet filter of a Port does not return exactly one result.
The following fields are removed from network and subnet filters without replacement:
|
@jichenjc for now I only added breaking changes and omitted new features. Do you think we should also include all new features here?
@tobiasgiese That was my goal, going forward I hope that every PR that makes changes to the CRDs also documents those changes in the book. |
ok, didn't get this , I am ok to just list the breaking changes :) thanks~ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-cluster-api-provider-openstack-e2e-test not sure why the gate failure ratio is high recently |
|
/hold cancel |
What this PR does / why we need it:
List backwards-incompatible changes made to the CRDs going from v1alpha4 to v1alpha5. I only added those I knew about and I understood. @mdbooth maybe you want to provide some more details about the Port and Network changes you can Emilio did, but I did not have the time to understand and document them.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1188
/hold