🏃 Add Scopes to pass data to services #1178
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/hold
|
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 3bde85f 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/623477c7431ec4000871e246 😎 Browse the preview: https://deploy-preview-1178--kubernetes-sigs-cluster-api-openstack.netlify.app |
k8s-ci-robot
added
cncf-cla: yes
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
I still like this in principal!
| Region: clientOpts.RegionName, | ||
| func NewService(scope *scope.Scope) (*Service, error) { | ||
| loadbalancerClient, err := openstack.NewLoadBalancerV2(scope.ProviderClient, gophercloud.EndpointOpts{ | ||
| Region: scope.ProviderClientOpts.RegionName, |
There was a problem hiding this comment.
I know we're already looking into project id, but it looks like region can also be extracted from the authentication response. Lets kill ProviderClientOpts entirely as soon as we can.
There was a problem hiding this comment.
Sounds good to me, I never really understood why the clientOpts were necessary.
There was a problem hiding this comment.
Should probably be a follow up, though! Lets leave it alone in for this PR.
|
/test all |
|
/retest |
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm I like the idea, for the questions that need follow up, we can anyway create a new one |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
What this PR does / why we need it:
This refactoring will make it easier to pass the
ProjectIDinto the services that need it (see #1146). The Scopes pattern is also used by other CAPI Providers:Context): https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/pkg/context/cluster_context.go/hold