Skip to content

🏃 sync OWNERS and OWNERS_ALIASES for v0.5 release branch#1170

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
mercedes-benz:schloc/release-0-5-sync-owners
Mar 9, 2022
Merged

🏃 sync OWNERS and OWNERS_ALIASES for v0.5 release branch#1170
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
mercedes-benz:schloc/release-0-5-sync-owners

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Mar 9, 2022

What this PR does / why we need it:

Syncs the OWNERS and OWNERS_ALIASES files to the same state as on master so the same who could approve to main are able to approve to the still in-use release branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [x ] squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Christian Schlotter christian.schlotter@daimler.com, Daimler TSS GmbH, Provider Information

Signed-off-by: Schlotter, Christian <christian.schlotter@daimler.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 2211e58

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6228b9bd9dd25100081a7270

😎 Browse the preview: https://deploy-preview-1170--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2022
@chrischdi chrischdi changed the base branch from main to release-0.5 March 9, 2022 14:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2022
@tobiasgiese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
Copy link
Contributor

@seanschneeweiss seanschneeweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

Because it was discussed in the office hours :-)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Mar 9, 2022

/lgtm

@chrischdi
Copy link
Member Author

We have to wait for #1169 first

@tobiasgiese
Copy link
Member

We have to wait for #1169 first

And we have to restart the test as #1169 is merged
/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit ec1ef36 into kubernetes-sigs:release-0.5 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants