Modify KubeVirtMachine API to include entire VM Template section#61
Merged
k8s-ci-robot merged 7 commits intokubernetes-sigs:mainfrom Dec 22, 2021
Merged
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
…achine Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
Contributor
Author
|
/cc @agradouski fyi, this handles the external namespace. The previous behavior you implemented still remains. The custom namespace is only used when the kubevirtMachine.Spec.VirtualMachineTemplate.Namespace is set to something other than "". |
Contributor
|
thanks for your PR @davidvossel! changes look great, tested locally. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agradouski, davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nunnatsa
pushed a commit
to nunnatsa/cluster-api-provider-kubevirt
that referenced
this pull request
Jan 12, 2025
…r-api-provider-kubevirt-mce-26 Red Hat Konflux update cluster-api-provider-kubevirt-mce-26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11
fixes #41
fixes #51
This modifies the KubeVirtMachine api to include the entire VM template section rather than just a VMI spec. This allows the following scenarios to be expressed which were not possible before.