Dockerized manager build script#42
Closed
davidvossel wants to merge 1 commit into
Closed
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Closed
Contributor
|
This is another PR #46 trying to solve the issue differently. |
Contributor
|
@davidvossel and @rmohr, what're your thoughts regarding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces an optional path for building the capk manager binary using a standardized docker container. This allows us to optionally decouple the golang build version from whatever is running locally on our dev machines.
running the following will use a golang base container to build the manager binary and dump it into the src tree's
bin/managerdirectory.The existing
make managerwithout usage of the CAPK_DOCKERIZED_BUILD env var remains unchanged, and will use the local go environment.