Skip to content

Dockerized manager build script#42

Closed
davidvossel wants to merge 1 commit into
kubernetes-sigs:mainfrom
davidvossel:dockerized-build-1
Closed

Dockerized manager build script#42
davidvossel wants to merge 1 commit into
kubernetes-sigs:mainfrom
davidvossel:dockerized-build-1

Conversation

@davidvossel
Copy link
Copy Markdown
Contributor

This introduces an optional path for building the capk manager binary using a standardized docker container. This allows us to optionally decouple the golang build version from whatever is running locally on our dev machines.

running the following will use a golang base container to build the manager binary and dump it into the src tree's bin/manager directory.

CAPK_DOCKERIZED_BUILD=true make manager

The existing make manager without usage of the CAPK_DOCKERIZED_BUILD env var remains unchanged, and will use the local go environment.

NONE

Signed-off-by: David Vossel <davidvossel@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidvossel
To complete the pull request process, please assign agradouski after the PR has been reviewed.
You can assign the PR to them by writing /assign @agradouski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cchengleo
Copy link
Copy Markdown
Contributor

This is another PR #46 trying to solve the issue differently.

@cchengleo
Copy link
Copy Markdown
Contributor

@davidvossel and @rmohr, what're your thoughts regarding the make manager target? Are we prefer to use volume or production image layers to cache for dependencies?

@davidvossel davidvossel closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants