Update klog dependency to v2#1
Conversation
This switches klog usage over to klog v2.5.0 to match the current version being used in k/k. This should also address some issues we're seeing that have since been fixed in klog between the quite old v1.0.0 and v2.5.0. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
Welcome @stmcginnis! |
elmiko
left a comment
There was a problem hiding this comment.
thanks for the PR @stmcginnis , this generally looks good to me but i have a quick question. does the root go.sum also need to be updated?
|
It doesn't appear so. Just to be safe, I deleted all klog lines from go.sum, then ran |
|
awesome, thanks again! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The klog v1 dependency used is quite old now, and the k/k repo has
switched to more recent v2 versions for quite some time now.
This updates klog usage to use the v2 package version.
Special notes for your reviewer:
This is part of an overall effort along with updating the k-sigs/cluster-api repo here:
kubernetes-sigs/cluster-api#4284