-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate identity type on user-assigned identities #5102
Conversation
Validate the identity type is 'UserAssigned' when using user-assigned identities. Signed-off-by: Bryan Cox <[email protected]>
Hi @bryan-cox. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
+ Coverage 51.17% 51.25% +0.07%
==========================================
Files 273 273
Lines 24616 24648 +32
==========================================
+ Hits 12597 12633 +36
+ Misses 11234 11229 -5
- Partials 785 786 +1 ☔ View full report in Codecov by Sentry. |
/test pull-cluster-api-provider-azure-e2e |
/test pull-cluster-api-provider-azure-e2e-aks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: e22355d27e38f57051d3d1c1ec1dfe80263cec5f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks again for working on this! 🚀 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Validate the identity type is 'UserAssigned' when using user-assigned identities.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4990
Special notes for your reviewer:
TODOs:
Release note: