feat: implement AzureMachinePool by devigned · Pull Request #483 · kubernetes-sigs/cluster-api-provider-azure

devigned · 2020-04-03T15:59:37Z

This PR implements machine pools for CAPZ using Azure Virtual Machine Scale Sets. In this PR, an /exp path is added similar to CAPI to be the home for the AzureMachinePool API and controller. The controller, api and service model borrows heavily from AzureMachine (there's a fair bit of copypasta, and I think there are opportunities to dry up a lot of this code).

TODOs

add networking details
add tests
add docs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #472

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add support for CAPI MachinePools via AzureMachinePools using Virtual Machine Scale Sets

devigned · 2020-04-22T17:48:05Z

When deleting a cluster, machinepool is not deleted. This needs to be resolved upstream and can be remedied by deleting the machinepool, then deleting the cluster.

kubernetes-sigs/cluster-api#2952

devigned · 2020-04-22T19:33:07Z

PSA: this PR is now able to be run end to end by running:

make tilt-up
CLUSTER_TEMPLATE=cluster-template-machinepool.yaml make create-workload-cluster

Please provide feedback.

CecileRobertMichon · 2020-05-01T22:26:49Z

@devigned I'm sorry to do this to you but... How doable would it be to break down this huge PR into individual commits for all the different components it touches (adding types, controllers, generated files, tests, mocks, docs, etc.) to facilitate reviews? (still one PR, just break down the commit history into smaller commits)

devigned · 2020-05-01T22:30:52Z

@CecileRobertMichon, what do you think of this separation:

docs
feature
tests & mocks
flavor

rbitia

Looks good! I wrote these comments from a view point of someone who is trying out machine pools after creating a cluster with the capz quickstart.

rbitia · 2020-05-01T22:44:36Z

+        "subscriptionId": "subscriptionID",
+        "aadClientId": "clientID",
+        "aadClientSecret": "secret",
+        "resourceGroup": "capz",


Could we make it easy for first time users and change the rg, cluster name etc, to what they set in the CAPI book quickstart?

These are just there for example. The flavor actually has environment vars which match the Quickstart.

Okay, sounds good!

CecileRobertMichon

/approve
/hold for docs review

Beautiful work @devigned 💯

CecileRobertMichon · 2020-05-04T17:44:43Z

/hold cancel
/approve
/lgtm

k8s-ci-robot · 2020-05-04T17:44:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Danny Brito <dannybrito@microsoft.com>

k8s-ci-robot requested review from awesomenix and vincepri April 3, 2020 15:59

k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Apr 3, 2020

alexeldeib reviewed Apr 3, 2020

View reviewed changes

Comment thread exp/api/v1alpha3/azuremachinepool_webhook.go Outdated

alexeldeib reviewed Apr 3, 2020

View reviewed changes

Comment thread exp/cloud/converters/vmss.go Outdated

devigned force-pushed the machinepool branch 5 times, most recently from 2a8537a to 1d79dc5 Compare April 6, 2020 23:50

CecileRobertMichon reviewed Apr 7, 2020

View reviewed changes

Comment thread cloud/services/virtualmachines/virtualmachines.go Outdated

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2020

devigned force-pushed the machinepool branch from 1d79dc5 to df640e8 Compare April 18, 2020 18:05

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2020

devigned force-pushed the machinepool branch 2 times, most recently from 2ff7025 to 2b58559 Compare April 21, 2020 16:27

CecileRobertMichon reviewed Apr 21, 2020

View reviewed changes

Comment thread exp/api/v1alpha3/azuremachinepool_types.go Outdated

CecileRobertMichon reviewed Apr 21, 2020

View reviewed changes

Comment thread exp/api/v1alpha3/azuremachinepool_webhook.go Outdated

CecileRobertMichon reviewed Apr 21, 2020

View reviewed changes

Comment thread exp/api/v1alpha3/types.go Outdated

devigned force-pushed the machinepool branch 2 times, most recently from 00c424e to 329b52c Compare April 22, 2020 19:01

devigned changed the title ~~[wip] implement AzureMachinePool~~ feat: implement AzureMachinePool Apr 22, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2020

devigned force-pushed the machinepool branch from 7377e1e to 1c93866 Compare May 1, 2020 21:59

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2020

devigned force-pushed the machinepool branch from 1c93866 to bd77c96 Compare May 1, 2020 22:05

rbitia reviewed May 1, 2020

View reviewed changes

devigned mentioned this pull request May 1, 2020

docs: AzureMachinePool documenation #589

Closed

devigned force-pushed the machinepool branch from bd77c96 to 306af31 Compare May 1, 2020 23:23

CecileRobertMichon approved these changes May 1, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020

devigned force-pushed the machinepool branch from 306af31 to f402ba8 Compare May 1, 2020 23:33

devigned added 5 commits May 1, 2020 16:34

docs: AzureMachinePool documenation

9e0dae2

feat: AzureMachinePool flavor

bb2119a

chore: change Tiltfile to follow idioms of CAPI

3eacaf3

feat: add MachinePool support with AzureMachinePool

d5e1b5c

test: tests for AzureMachinePool

527e050

devigned force-pushed the machinepool branch from f402ba8 to 527e050 Compare May 1, 2020 23:35

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2020

k8s-ci-robot assigned CecileRobertMichon May 4, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2020

k8s-ci-robot merged commit 4d682a1 into kubernetes-sigs:master May 4, 2020

k8s-ci-robot added this to the v0.5 milestone May 4, 2020

devigned deleted the machinepool branch May 4, 2020 20:29

This was referenced May 13, 2020

Implement AWSMachinePools using ASG kubernetes-sigs/cluster-api-provider-aws#1722

Closed

Implement GCPMachinePool using MIGs kubernetes-sigs/cluster-api-provider-gcp#297

Open

devigned mentioned this pull request May 21, 2020

REQUEST: New membership for @devigned kubernetes/org#1891

Closed

6 tasks

willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025

Added filtering of tags for trigger (kubernetes-sigs#483)

61aaffc

Co-authored-by: Danny Brito <dannybrito@microsoft.com>

Conversation

devigned commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devigned commented Apr 22, 2020

Uh oh!

devigned commented Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CecileRobertMichon commented May 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devigned commented May 1, 2020

Uh oh!

rbitia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rbitia May 1, 2020

Choose a reason for hiding this comment

Uh oh!

devigned May 1, 2020

Choose a reason for hiding this comment

Uh oh!

rbitia May 4, 2020

Choose a reason for hiding this comment

Uh oh!

CecileRobertMichon left a comment

Choose a reason for hiding this comment

Uh oh!

CecileRobertMichon commented May 4, 2020

Uh oh!

k8s-ci-robot commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

devigned commented Apr 3, 2020 •

edited

Loading

devigned commented Apr 22, 2020 •

edited

Loading

CecileRobertMichon commented May 1, 2020 •

edited

Loading