-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Update capi to v0.3.2 #464
🏃 Update capi to v0.3.2 #464
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4f79eba
to
92674ac
Compare
@vincepri @chuckha E2E is failing after moving to the new release with error
which seems related to kubernetes-sigs/cluster-api#2674
Any ideas? |
@CecileRobertMichon looking at https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/config.go#L283-L295 and https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/config_constants.go#L19-L62, it looks like the default configuration does not set the KubernetesVersion by default unless you call the .Defaults() method on the config resource (which doesn't appear to be done when calling |
we have this PR #457 which one we will move forward? |
0de551e
to
71d56b5
Compare
405374c
to
ac960b0
Compare
ac960b0
to
f38bafd
Compare
e7daf8b
to
eac4633
Compare
/lgtm |
@jsturtevant: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
What this PR does / why we need it: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.3.2
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: