Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Update capi to v0.3.2 #464

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v0.3.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update Cluster API to v0.3.2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2020
@CecileRobertMichon
Copy link
Contributor Author

@vincepri @chuckha E2E is failing after moving to the new release with error

admission webhook "validation.machine.cluster.x-k8s.io" denied the request: Machine.cluster.x-k8s.io "capz-vhbqic-controlplane-0" is invalid: spec.version: Invalid value: "": must be a valid semantic version

which seems related to kubernetes-sigs/cluster-api#2674
even though we are using the capi framework default K8s version from the default config:

defaultConfig, _ := framework.DefaultConfig()

Version: pointer.StringPtr(defaultConfig.KubernetesVersion),

Version: pointer.StringPtr(defaultConfig.KubernetesVersion),

Any ideas?

@detiber
Copy link
Member

detiber commented Mar 20, 2020

@CecileRobertMichon looking at https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/config.go#L283-L295 and https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/config_constants.go#L19-L62, it looks like the default configuration does not set the KubernetesVersion by default unless you call the .Defaults() method on the config resource (which doesn't appear to be done when calling framework.DefaultConfig().

@cpanato
Copy link
Member

cpanato commented Mar 20, 2020

we have this PR #457 which one we will move forward?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2020
@CecileRobertMichon CecileRobertMichon changed the title 🏃 Update capi to v0.3.2 🏃 Update capi to v0.3.2 Mar 20, 2020
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nader-ziada
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 70edc51 into kubernetes-sigs:master Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Mar 20, 2020
@CecileRobertMichon CecileRobertMichon deleted the capi-v0.3.2 branch April 13, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants