-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk encryption options documentation #4415
Add disk encryption options documentation #4415
Conversation
Welcome @bryan-cox! |
Hi @bryan-cox. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Happy to squash those two commits into one. Just left them separate for now for peer review. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4415 +/- ##
==========================================
+ Coverage 61.91% 61.96% +0.05%
==========================================
Files 188 188
Lines 18725 18761 +36
==========================================
+ Hits 11593 11625 +32
- Misses 6494 6498 +4
Partials 638 638 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @bryan-cox, thank you! I just had a few nitpicks.
@mboersma -Thanks for the feedback! I've addressed all the comments. Just let me know when you think it's good to go and I'll squash them all into one commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Squash whenever time permits and I'm happy to approve this PR.
LGTM label has been added. Git tree hash: 947d63791074089f7bfefd3d3b0bf4b532368430
|
095bbde
to
1777054
Compare
Commits are all squashed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR reorganizes the disk pages into their own section and adds a new documentation section discussing disk encryption options.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):N/A
Special notes for your reviewer:
TODOs:
Release note: