Skip to content

[release-1.3] Update to compute API 2021-11-01 #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2022
Merged

[release-1.3] Update to compute API 2021-11-01 #2361

merged 2 commits into from
Jun 8, 2022

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 7, 2022 •
edited by mboersma
Loading

This is an automated cherry-pick of #2288

This appears to be a prerequisite to merging #2357

/assign mboersma

NONE

invidian added 2 commits June 7, 2022 12:42
@invidian
Update to compute API 2021-11-01
9933a73 
To allow access to CommunityGalleryImageID field in ImageReference.

Refs kubernetes-sigs#2267

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian
api/v1beta1/azureimage_validation.go: fix typo in function name
d26cdb5 
Signed-off-by: Mateusz Gozdek <[email protected]>
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 7, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 7, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2022
@jackfrancis
Copy link
Contributor

jackfrancis commented Jun 7, 2022

/retest

1 similar comment
@mboersma
Copy link
Contributor

mboersma commented Jun 7, 2022

/retest

@mboersma
Copy link
Contributor

mboersma commented Jun 7, 2022

E0607 20:36:13.276361 1 controller.go:304] controller/azuremachine "msg"="Reconciler error" "error"="failed to configure azure settings and credentials for Identity: Unable to fetch ClientSecret: Secret "cluster-identity-secret" not found" "name"="clusterctl-upgrade-f5splb-md-0-6kt72" "namespace"="clusterctl-upgrade" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="AzureMachine"

@jackfrancis
Copy link
Contributor

jackfrancis commented Jun 8, 2022

/retest

jackfrancis
jackfrancis approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jun 8, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jun 8, 2022

/retest

1 similar comment
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jun 8, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 39440d6 into kubernetes-sigs:release-1.3 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@devigned devigned Awaiting requested review from devigned

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

6 participants

@k8s-infra-cherrypick-robot @jackfrancis @mboersma @CecileRobertMichon @k8s-ci-robot @invidian