Skip to content

[release-0.5] use aks-managed-poolName also for vmss match#2028

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:release-0.5from
k8s-infra-cherrypick-robot:cherry-pick-2025-to-release-0.5
Feb 3, 2022
Merged

[release-0.5] use aks-managed-poolName also for vmss match#2028
k8s-ci-robot merged 2 commits into
kubernetes-sigs:release-0.5from
k8s-infra-cherrypick-robot:cherry-pick-2025-to-release-0.5

Conversation

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Feb 1, 2022

This is an automated cherry-pick of #2025

/assign CecileRobertMichon

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Feb 1, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 1, 2022
Merged
3 tasks
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from cpanato February 1, 2022 18:16
@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from shysank February 1, 2022 18:16
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 1, 2022
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 1, 2022

/assign @alexeldeib

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 1, 2022

AKS cluster create is pretty much already broken on the v1alpha4 branch, https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-e2e-full-v1alpha4

we would need to backport #1850 to fully fix it

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Feb 2, 2022

@CecileRobertMichon do we want to fix AKS for v1alpha4? If not, we probably want to update test-infra so we no longer run these tests against release-0.5

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 2, 2022

I'd like to try to fix it, but will need to cherry-pick #1850 in this PR

@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 2, 2022
Merged
3 tasks
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Feb 2, 2022

@CecileRobertMichon #2039

@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 2, 2022
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2022
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 2, 2022

will need to wait for #2036 to merge first

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 2, 2022

/retest

@CecileRobertMichon CecileRobertMichon force-pushed the cherry-pick-2025-to-release-0.5 branch from e03ce1e to 7c505f0 Compare February 2, 2022 23:06
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 3, 2022

@jackfrancis this should be good to go (exp test passed ✅ )

jackfrancis
jackfrancis approved these changes Feb 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2022
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Feb 3, 2022

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d2c65c0 into kubernetes-sigs:release-0.5 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@shysank shysank Awaiting requested review from shysank

Assignees

@jackfrancis jackfrancis

@alexeldeib alexeldeib

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.5

Development

Successfully merging this pull request may close these issues.

7 participants

@k8s-infra-cherrypick-robot @CecileRobertMichon @jackfrancis @k8s-ci-robot @alexeldeib @zmalik @devigned