remove machinepool-specific test templates#2018
Merged
Merged
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/provider/azure
Contributor
Author
|
/assign @CecileRobertMichon |
Contributor
|
/pull-cluster-api-provider-azure-e2e-full |
jackfrancis
force-pushed
the
template-cleanup
branch
from
c7480c1 to
07ffe4a
Compare
k8s-ci-robot
added
size/XL
Contributor
Author
|
/retest |
Contributor
|
/pull-cluster-api-provider-azure-e2e-full |
Contributor
|
/test pull-cluster-api-provider-azure-e2e-full |
Contributor
Author
|
/retest |
Contributor
|
/retest prow job got stuck and timed out |
Contributor
|
AKS test is broken, should be fixed as soon as #2025 merges |
jackfrancis
force-pushed
the
template-cleanup
branch
from
07ffe4a to
b48af86
Compare
Contributor
|
/test pull-cluster-api-provider-azure-e2e-full |
jackfrancis
force-pushed
the
template-cleanup
branch
from
b48af86 to
d20a12f
Compare
jackfrancis
force-pushed
the
template-cleanup
branch
from
d20a12f to
78f2104
Compare
Contributor
Author
|
/test pull-cluster-api-provider-azure-e2e-full |
Contributor
|
test timed out /test pull-cluster-api-provider-azure-e2e-full |
Contributor
|
/retest |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/release-note-none |
k8s-ci-robot
added
release-note-none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This PR removes three test templates which were created to discretely test user-assigned-identity, system-assigned-identity, and VNETs w/ more than one subnet using MachinePools for nodes. Because we're already testing those three bits of functionality in the existing templates (albeit not necessarily on clusters w/ MachinePools), let's prune these templates in the interest of keeping our collection of cluster templates lean.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: