Make inbound NAT rules reconcile/delete async#1870
Conversation
|
Hi @Jont828. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
034fe95 to
ea18bfc
Compare
9c9eebb to
68e182e
Compare
68e182e to
614a29e
Compare
e3eb58b to
cc0ecc5
Compare
005e2c3 to
a0fb7d3
Compare
CecileRobertMichon
left a comment
There was a problem hiding this comment.
lgtm
/assign @mboersma
devigned
left a comment
There was a problem hiding this comment.
Code / tests look solid. Nice work!
lgtm
a0fb7d3 to
db5d928
Compare
|
/lgtm 🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
db5d928 to
8bd2880
Compare
|
@Jont828: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Let's go!!! |
What type of PR is this?
/kind feature
What this PR does / why we need it: Implementation of an async service for inbound NAT rules as a follow up for #1610 and #1541.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1712
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: