Skip to content

Make inbound NAT rules reconcile/delete async#1870

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Jont828:async-inboundnatrules
Jan 12, 2022
Merged

Make inbound NAT rules reconcile/delete async#1870
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Jont828:async-inboundnatrules

Conversation

@Jont828
Copy link
Copy Markdown
Contributor

@Jont828 Jont828 commented Nov 16, 2021

What type of PR is this?

/kind feature
What this PR does / why we need it: Implementation of an async service for inbound NAT rules as a follow up for #1610 and #1541.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1712

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Make inbound NAT rules reconcile/delete async

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2021
Comment thread azure/services/inboundnatrules/client.go Outdated
Comment thread azure/services/inboundnatrules/inboundnatrules.go
Comment thread azure/services/inboundnatrules/inboundnatrules.go Outdated
Comment thread azure/scope/machine.go Outdated
Comment thread azure/services/inboundnatrules/spec.go Outdated
Comment thread azure/services/inboundnatrules/spec.go Outdated
Comment thread azure/services/inboundnatrules/spec.go
Comment thread azure/scope/machine.go Outdated
Comment thread azure/scope/machine.go Outdated
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2021
@Jont828 Jont828 force-pushed the async-inboundnatrules branch 2 times, most recently from 034fe95 to ea18bfc Compare December 2, 2021 00:21
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2021
Comment thread azure/scope/machine.go Outdated
Comment thread azure/scope/machine_test.go Outdated
Comment thread azure/services/inboundnatrules/client.go Outdated
Comment thread azure/services/inboundnatrules/spec.go
@Jont828 Jont828 force-pushed the async-inboundnatrules branch 2 times, most recently from 9c9eebb to 68e182e Compare January 10, 2022 23:30
Comment thread azure/converters/inboundnatrules.go Outdated
Comment thread azure/services/inboundnatrules/inboundnatrules.go
Comment thread azure/services/inboundnatrules/spec.go
@Jont828 Jont828 force-pushed the async-inboundnatrules branch from 68e182e to 614a29e Compare January 11, 2022 21:46
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2022
@Jont828 Jont828 force-pushed the async-inboundnatrules branch from e3eb58b to cc0ecc5 Compare January 11, 2022 23:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2022
@Jont828 Jont828 force-pushed the async-inboundnatrules branch 3 times, most recently from 005e2c3 to a0fb7d3 Compare January 12, 2022 00:25
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

/assign @mboersma

Comment thread azure/scope/machine_test.go
Comment thread azure/services/inboundnatrules/spec.go Outdated
Copy link
Copy Markdown
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code / tests look solid. Nice work!

lgtm

@Jont828 Jont828 force-pushed the async-inboundnatrules branch from a0fb7d3 to db5d928 Compare January 12, 2022 17:58
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

/lgtm
/approve

🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@Jont828 Jont828 force-pushed the async-inboundnatrules branch from db5d928 to 8bd2880 Compare January 12, 2022 20:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 12, 2022

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff 8bd2880 link false /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit c26c92c into kubernetes-sigs:main Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 12, 2022
@Jont828
Copy link
Copy Markdown
Contributor Author

Jont828 commented Jan 12, 2022

Let's go!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

async inboundnatrules

5 participants