Make availability set reconcile/delete async by Jont828 · Pull Request #1861 · kubernetes-sigs/cluster-api-provider-azure

Jont828 · 2021-11-12T23:38:48Z

What type of PR is this?

/kind feature
What this PR does / why we need it: Implementation of an async service for availability sets as a follow up for #1610 and #1541.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1709

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Make availability set reconcile/delete async

linux-foundation-easycla · 2021-11-12T23:38:52Z

The committers are authorized under a signed CLA.

✅ Jonathan Tong (fae9932)

k8s-ci-robot · 2021-11-12T23:38:56Z

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CecileRobertMichon · 2021-11-16T23:04:56Z

/ok-to-test

CecileRobertMichon · 2021-11-16T23:06:28Z

+
+		m.cache.availabilitySetSKU, err = skuCache.Get(ctx, string(compute.AvailabilitySetSkuTypesAligned), resourceskus.AvailabilitySets)
+		if err != nil {
+			// TODO: verify error message


Related to #1828

CecileRobertMichon

@Jont828 can you please squash the commits?

lgtm

k8s-ci-robot · 2021-12-14T20:32:46Z

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	`020a2b6`	link	false	`/test pull-cluster-api-provider-azure-apidiff`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CecileRobertMichon · 2021-12-14T21:35:34Z

/lgtm
/approve

k8s-ci-robot · 2021-12-14T21:35:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 12, 2021

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2021

Jont828 changed the title ~~Make availability set reconcile/delete async~~ Make availability set reconcile/delete async [WIP] Nov 12, 2021

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2021

k8s-ci-robot requested review from CecileRobertMichon and devigned November 12, 2021 23:39

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 12, 2021

Jont828 force-pushed the async-availabilitysets branch from 26ae25e to 42c936c Compare November 12, 2021 23:46

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2021

CecileRobertMichon reviewed Nov 16, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2021

Jont828 force-pushed the async-availabilitysets branch 2 times, most recently from fae9932 to 1c20edc Compare December 1, 2021 23:56

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2021

Jont828 commented Dec 2, 2021

View reviewed changes

Comment thread azure/scope/machine.go Outdated

Jont828 commented Dec 2, 2021

View reviewed changes

Comment thread azure/scope/machine.go Outdated

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021

Jont828 force-pushed the async-availabilitysets branch from e1b3ed0 to ce633c4 Compare December 9, 2021 01:31

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2021

Jont828 changed the title ~~Make availability set reconcile/delete async [WIP]~~ Make availability set reconcile/delete async Dec 9, 2021

Jont828 force-pushed the async-availabilitysets branch from ce633c4 to 3df0ede Compare December 9, 2021 17:46

k8s-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2021

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 9, 2021

Jont828 force-pushed the async-availabilitysets branch 2 times, most recently from 21236d1 to ad195d4 Compare December 10, 2021 00:30