Make disks delete async by Jont828 · Pull Request #1844 · kubernetes-sigs/cluster-api-provider-azure

Jont828 · 2021-11-09T21:17:50Z

What type of PR is this?

/kind feature
What this PR does / why we need it: Implementation of an async service for disks as a follow up for #1610 and #1541.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1711

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Make disks delete async

k8s-ci-robot · 2021-11-09T21:17:59Z

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CecileRobertMichon · 2021-11-09T22:20:33Z

/ok-to-test

linux-foundation-easycla · 2021-11-15T20:37:11Z

The committers are authorized under a signed CLA.

✅ Jonathan Tong (dd31469, e96e496, 4ad6586, 7f41d50)

Jont828 · 2021-11-18T23:30:02Z

@CecileRobertMichon Do you think it would make sense to add UpdatePutStatus(infrav1.DisksReadyCondition, serviceName, err) to the reconciler for async VMs? Since the reconciler for disks is a no-op we could try to update the status in the code that's responsible for creating the disks.

Jont828 · 2021-11-23T22:47:52Z

/retest

CecileRobertMichon · 2021-11-23T23:54:58Z

@Jont828 please squash commits

Jont828 · 2021-11-24T02:35:03Z

/retest

CecileRobertMichon

lgtm besides two minor comments

Jont828 · 2021-11-24T23:45:03Z

/retest

Jont828 · 2021-11-25T03:16:23Z

/retest

Jont828 · 2021-11-29T17:49:44Z

/retest

CecileRobertMichon

/lgtm
/approve
/retest

k8s-ci-robot · 2021-11-30T17:10:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CecileRobertMichon · 2021-11-30T18:14:44Z

possibly a flake?

/retest

Jont828 · 2021-11-30T20:36:35Z

/retest

CecileRobertMichon · 2021-11-30T21:29:47Z

/test pull-cluster-api-provider-azure-e2e

the test is going to fail, restarting to gain time. Going to look into the different failures.

CecileRobertMichon · 2021-11-30T23:13:37Z

/retest

quota issues on the sub should be mitigated

CecileRobertMichon · 2021-12-01T00:35:24Z

the latest one wasn't a quota issue, going to investigate separately (seems unrelated to this PR)

/retest

Jont828 · 2021-12-01T18:50:49Z

/retest

CecileRobertMichon · 2021-12-01T21:25:10Z

this PR does not want to merge...

Issues we've run into so far:

Context deadline exceeded on RG GET #1901
quota issues (resolved)
control planes not creating/joining (looking)
service curl flakes

/retest

k8s-ci-robot · 2021-12-01T21:26:45Z

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	`4c58842`	link	false	`/test pull-cluster-api-provider-azure-apidiff`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2021

k8s-ci-robot requested review from mboersma and shysank November 9, 2021 21:18

k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 9, 2021

Jont828 force-pushed the async-disks branch from ca63d3f to dd31469 Compare November 9, 2021 21:20

CecileRobertMichon reviewed Nov 9, 2021

View reviewed changes

Comment thread api/v1beta1/conditions_consts.go

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2021

Jont828 changed the title ~~Make disks delete async [WIP]~~ Make disks delete async Nov 11, 2021

CecileRobertMichon reviewed Nov 12, 2021

View reviewed changes

Comment thread azure/services/disks/spec.go

Jont828 force-pushed the async-disks branch from 59a655f to 4ad6586 Compare November 15, 2021 21:07

CecileRobertMichon reviewed Nov 16, 2021

View reviewed changes

Comment thread azure/scope/cluster.go Outdated

Jont828 commented Nov 17, 2021

View reviewed changes

Comment thread azure/services/disks/spec.go Outdated

Jont828 force-pushed the async-disks branch from 7f41d50 to e440beb Compare November 17, 2021 21:59

CecileRobertMichon reviewed Nov 23, 2021

View reviewed changes

Comment thread azure/services/disks/disks.go Outdated

CecileRobertMichon reviewed Nov 23, 2021

View reviewed changes

Comment thread azure/services/disks/disks.go Outdated

Jont828 force-pushed the async-disks branch 3 times, most recently from df18a8e to ad921a7 Compare November 24, 2021 00:23

CecileRobertMichon reviewed Nov 24, 2021

View reviewed changes

Comment thread azure/services/disks/spec.go Outdated

CecileRobertMichon reviewed Nov 24, 2021

View reviewed changes

Comment thread azure/services/virtualmachines/virtualmachines.go

CecileRobertMichon reviewed Nov 24, 2021

View reviewed changes

Jont828 force-pushed the async-disks branch from ad921a7 to 31ae18f Compare November 24, 2021 20:52

CecileRobertMichon reviewed Nov 29, 2021

View reviewed changes

Comment thread azure/services/disks/spec.go Outdated

Comment thread azure/services/disks/client.go Outdated

Jont828 force-pushed the async-disks branch 2 times, most recently from 6229bdf to a43b50f Compare November 30, 2021 00:04

Make disk delete async

4c58842

Jont828 force-pushed the async-disks branch from a43b50f to 4c58842 Compare November 30, 2021 01:04

CecileRobertMichon reviewed Nov 30, 2021

View reviewed changes

k8s-ci-robot assigned CecileRobertMichon Nov 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021

CecileRobertMichon mentioned this pull request Nov 30, 2021

Refactor async service to use an async reconciler interface and handle getting existing resources #1874

Merged

3 tasks

k8s-ci-robot merged commit 69f3426 into kubernetes-sigs:main Dec 1, 2021

k8s-ci-robot added this to the v1.1 milestone Dec 1, 2021

Jont828 mentioned this pull request Dec 22, 2021

REQUEST: New membership for Jont828 kubernetes/org#3156

Closed

7 tasks

Conversation

Jont828 commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 9, 2021

Uh oh!

Uh oh!

CecileRobertMichon commented Nov 9, 2021

Uh oh!

Uh oh!

linux-foundation-easycla Bot commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jont828 commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jont828 commented Nov 23, 2021

Uh oh!

CecileRobertMichon commented Nov 23, 2021

Uh oh!

Uh oh!

Uh oh!

Jont828 commented Nov 24, 2021

Uh oh!

Uh oh!

Uh oh!

CecileRobertMichon left a comment

Choose a reason for hiding this comment

Uh oh!

Jont828 commented Nov 24, 2021

Uh oh!

Jont828 commented Nov 25, 2021

Uh oh!

Jont828 commented Nov 29, 2021

Uh oh!

Uh oh!

Uh oh!

CecileRobertMichon left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Nov 30, 2021

Uh oh!

CecileRobertMichon commented Nov 30, 2021

Uh oh!

Jont828 commented Nov 30, 2021

Uh oh!

CecileRobertMichon commented Nov 30, 2021

Uh oh!

CecileRobertMichon commented Nov 30, 2021

Uh oh!

CecileRobertMichon commented Dec 1, 2021

Uh oh!

Jont828 commented Dec 1, 2021

Uh oh!

CecileRobertMichon commented Dec 1, 2021

Uh oh!

k8s-ci-robot commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jont828 commented Nov 9, 2021 •

edited

Loading

linux-foundation-easycla Bot commented Nov 15, 2021 •

edited

Loading

Jont828 commented Nov 18, 2021 •

edited

Loading

k8s-ci-robot commented Dec 1, 2021 •

edited

Loading