Make route tables reconcile/delete async#1686
Merged
k8s-ci-robot merged 2 commits intoJan 11, 2022
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/provider/azure
Contributor
Author
|
/hold to rebase on top of #1684 |
k8s-ci-robot
added
do-not-merge/hold
3 tasks
CecileRobertMichon
force-pushed
the
async-routetables
branch
from
9121e36 to
328286e
Compare
k8s-ci-robot
removed
the
needs-rebase
CecileRobertMichon
force-pushed
the
async-routetables
branch
4 times, most recently
from
62085f0 to
57c0b46
Compare
k8s-ci-robot
added
the
needs-rebase
CecileRobertMichon
force-pushed
the
async-routetables
branch
from
57c0b46 to
1f727ee
Compare
k8s-ci-robot
removed
the
needs-rebase
CecileRobertMichon
force-pushed
the
async-routetables
branch
3 times, most recently
from
103d872 to
b20c04c
Compare
Contributor
Author
k8s-ci-robot
removed
the
do-not-merge/hold
CecileRobertMichon
force-pushed
the
async-routetables
branch
from
6b2c3b2 to
b2302ea
Compare
This was referenced Jan 8, 2022
Jont828
reviewed
Jan 10, 2022
Jont828
reviewed
Jan 10, 2022
Jont828
reviewed
Jan 10, 2022
CecileRobertMichon
force-pushed
the
async-routetables
branch
3 times, most recently
from
9e6748c to
e8e8f94
Compare
CecileRobertMichon
force-pushed
the
async-routetables
branch
from
e8e8f94 to
5abd056
Compare
CecileRobertMichon
force-pushed
the
async-routetables
branch
from
5abd056 to
229f425
Compare
Contributor
|
@CecileRobertMichon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
devigned
approved these changes
Jan 11, 2022
| // If the resource does not exist, or we do not care about existing parameters to update the resource, existing should be nil. | ||
| // If no update is needed on the resource, Parameters should return nil. | ||
| Parameters(existing interface{}) (interface{}, error) | ||
| Parameters(existing interface{}) (params interface{}, err error) |
Contributor
There was a problem hiding this comment.
func Parameters[T any](existing T) (params T, err error)Will be kind of nice. No action to take from this, just commenting.
Contributor
Author
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
just curious, was this a flake? |
Contributor
Author
|
yes it seemed like a prow infra flake, the test didn't even start running |
Contributor
Author
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shysank The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it: Implements async reconciliation and delete for the route tables service. Follow up on #1610 and #1541.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: