Replaced Windows with Windows + WSL2#1621
Conversation
|
Hi @sayantani11. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@CecileRobertMichon I don't know if the install make section was kept empty for some valid reason but I tried writing the commands there as well, if it creates problem I can remove it as well. |
CecileRobertMichon
left a comment
There was a problem hiding this comment.
/lgtm
/assign @jsturtevant
jsturtevant
left a comment
There was a problem hiding this comment.
minor comment otherwise lgtm. Thanks for your contribution!
|
@sayantani11 can you please squash the commits? |
|
@CecileRobertMichon I actually tried but there's some problem with this branch, and I am unable to. If we don't squash the commits, will that be a problem? |
|
We can use the following to squash on merge: /label tide/merge-method-squash |
|
/lgtm In general, I try to avoid using tide/merge-method-squash because it omits the pr from release notes but in this case there is no release note so should be fine |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1608
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: