Enable tests against existing workload cluster#1350
Merged
k8s-ci-robot merged 1 commit intoMay 4, 2021
Merged
Conversation
Contributor
Author
|
/assign @chewong @mboersma @nader-ziada |
chewong
reviewed
Apr 29, 2021
c9167d9 to
77f9351
Compare
3 tasks
77f9351 to
239423a
Compare
Contributor
Author
|
the windows failure was Haven't seen this error before. will keep an eye out for it |
239423a to
d324efd
Compare
Contributor
CecileRobertMichon
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
The failure here was #1328 which i've had some success fixing in #1351 (comment) /test pull-cluster-api-provider-azure-e2e-windows |
Contributor
Author
|
/test pull-cluster-api-provider-azure-e2e-windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When developing new e2e test specs or working on the framework it is time consuming to wait for a cluster to be provisioned. This enables reusing existing workload cluster:
Assuming you already have a kind management cluster and ran e2e once which created a workload cluster called
capz-e2e-uf9yll:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: