Skip to content

Enable tests against existing workload cluster#1350

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:enable-tests-against-existing
May 4, 2021
Merged

Enable tests against existing workload cluster#1350
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:enable-tests-against-existing

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
When developing new e2e test specs or working on the framework it is time consuming to wait for a cluster to be provisioned. This enables reusing existing workload cluster:

Assuming you already have a kind management cluster and ran e2e once which created a workload cluster called capz-e2e-uf9yll:

export LOCAL_ONLY=true 
export SKIP_CLEANUP=true 
export GINKGO_FOCUS=".*Windows.Enabled.*" 
export WINDOWS=true
export CLUSTERNAME=capz-e2e-uf9yll
export SKIP_CREATE_MGMT_CLUSTER=true
export KUBECONFIG=/home/jstur/projects/cluster-api-provider-azure/kubeconfig.e2e

./scripts/ci-e2e.sh

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Apr 29, 2021
@jsturtevant
Copy link
Copy Markdown
Contributor Author

jsturtevant commented Apr 29, 2021

/assign @chewong @mboersma @nader-ziada

Comment thread docs/development.md Outdated
Comment thread test/e2e/common.go Outdated
Comment thread test/e2e/common.go Outdated
Comment thread test/e2e/common.go
@jsturtevant jsturtevant force-pushed the enable-tests-against-existing branch from c9167d9 to 77f9351 Compare April 29, 2021 23:25
@jsturtevant jsturtevant mentioned this pull request Apr 29, 2021
3 tasks
Comment thread docs/development.md Outdated
@jsturtevant jsturtevant force-pushed the enable-tests-against-existing branch from 77f9351 to 239423a Compare May 3, 2021 16:25
@jsturtevant
Copy link
Copy Markdown
Contributor Author

the windows failure was

Delete "https://capz-e2e-7xp181-620890e5.westus2.cloudapp.azure.com:6443/api/v1/namespaces/default/services/webqki40r-elb": http2: client connection lost

Haven't seen this error before. will keep an eye out for it
/test pull-cluster-api-provider-azure-e2e-windows

Comment thread docs/development.md Outdated
Comment thread test/e2e/azure_test.go Outdated
Comment thread test/e2e/conformance_test.go Outdated
@jsturtevant jsturtevant force-pushed the enable-tests-against-existing branch from 239423a to d324efd Compare May 3, 2021 21:56
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2021
@jsturtevant
Copy link
Copy Markdown
Contributor Author

The failure here was #1328 which i've had some success fixing in #1351 (comment)

/test pull-cluster-api-provider-azure-e2e-windows

@jsturtevant
Copy link
Copy Markdown
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

@k8s-ci-robot k8s-ci-robot merged commit 62fef6f into kubernetes-sigs:master May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants