Add bootstrap failure detection proposal#1076
Merged
k8s-ci-robot merged 1 commit intoDec 23, 2020
Merged
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/provider/azure
Contributor
Author
|
/assign @devigned @nader-ziada |
devigned
suggested changes
Dec 15, 2020
Contributor
devigned
left a comment
devigned
left a comment
There was a problem hiding this comment.
Only a superficial change. Looks great.
Co-authored-by: David Justice <devigned@users.noreply.github.com>
CecileRobertMichon
force-pushed
the
bootstrap-detection-proposal
branch
from
a75e985 to
2518d26
Compare
Contributor
|
lgtm |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it: Moving the bootstrap failure detection proposal from the google doc now that it is implementable. cc @jackfrancis
Depends on kubernetes-sigs/cluster-api#3716
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #603
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: