Skip to content

Adds simple Exists implementation to machine actuator#67

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
chuckha:exists
Sep 20, 2018
Merged

Adds simple Exists implementation to machine actuator#67
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
chuckha:exists

Conversation

@chuckha
Copy link
Copy Markdown
Contributor

@chuckha chuckha commented Aug 31, 2018

Signed-off-by: Chuck Ha chuck@heptio.com

I'm not sure if this makes sense to merge now, but it's a little bit of code/test implements a very basic existence check

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2018
detiber
detiber reviewed Aug 31, 2018
View reviewed changes
Comment thread cloud/aws/actuators/machine/actuator_test.go Outdated
Copy link
Copy Markdown
Contributor

@detiber detiber Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Running rather than running?

Copy link
Copy Markdown
Contributor Author

@chuckha chuckha Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. actually i should probably use a constant assuming the ec2 sdk defines instance states as constants.

chuckha
chuckha commented Sep 4, 2018
View reviewed changes
Comment thread cloud/aws/actuators/machine/actuator.go Outdated
Copy link
Copy Markdown
Contributor Author

@chuckha chuckha Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this excessive?

detiber
detiber reviewed Sep 5, 2018
View reviewed changes
Comment thread cloud/aws/actuators/machine/actuator_test.go Outdated
Copy link
Copy Markdown
Contributor

@detiber detiber Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a positive test case here as well?

Copy link
Copy Markdown
Contributor Author

@chuckha chuckha Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think the pattern outlined in my other pr (#74) makes this a lot nicer

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2018
@chuckha chuckha force-pushed the exists branch 2 times, most recently from 9396a44 to 4e99a30 Compare September 6, 2018 15:31
@chuckha
Copy link
Copy Markdown
Contributor Author

chuckha commented Sep 6, 2018

Test deleted because the actuator test covered the test cases of the instance_test.go file. If we need to specifically test one piece of instance we can do that, but we should prefer the more integration style testing where we use the real actuator and the real service with a mocked out ec2.

@chuckha
Copy link
Copy Markdown
Contributor Author

chuckha commented Sep 6, 2018

/retest

1 similar comment
@chuckha
Copy link
Copy Markdown
Contributor Author

chuckha commented Sep 6, 2018

/retest

@phyber phyber mentioned this pull request Sep 12, 2018
Closed
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 17, 2018
chuckha
chuckha commented Sep 17, 2018
View reviewed changes
Comment thread cloud/aws/actuators/machine/actuator_test.go Outdated
Copy link
Copy Markdown
Contributor Author

@chuckha chuckha Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will convert to gomock later

@chuckha chuckha force-pushed the exists branch 3 times, most recently from 02c4f85 to 3006bd9 Compare September 19, 2018 13:24
@vincepri
Copy link
Copy Markdown
Member

vincepri commented Sep 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2018
@phyber phyber mentioned this pull request Sep 20, 2018
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018
Chuck Ha added 2 commits September 20, 2018 10:13
Adds simple Exists implementation to machine actuator
be2d6fb 
Remove the machine actuator test for now.

Trying to test it will be possible, but it will be a *ton* of work and
right now it's not worth the effort.

Exports the ec2 service's EC2 field.

Signed-off-by: Chuck Ha <chuck@heptio.com>
Update deps
2b8acca 
Signed-off-by: Chuck Ha <chuck@heptio.com>
@detiber
Copy link
Copy Markdown
Contributor

detiber commented Sep 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit d3df0ea into kubernetes-sigs:master Sep 20, 2018
csrwng pushed a commit to csrwng/cluster-api-provider-aws that referenced this pull request Oct 22, 2018
@openshift-merge-robot
Merge pull request kubernetes-sigs#67 from enxebre/crds
261db4a 
Migrate to CRDs - WIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

1 more reviewer

@detiber detiber detiber left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@detiber detiber

@vincepri vincepri

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chuckha @k8s-ci-robot @vincepri @detiber