Add cli flag to supply namespace for capa controller to watch for capi objects#607
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom Feb 26, 2019
Merged
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
ashish-amarnath
changed the title
detiber
reviewed
Feb 25, 2019
vincepri
reviewed
Feb 25, 2019
Member
There was a problem hiding this comment.
Should we define this outside the main function instead?
Contributor
Author
There was a problem hiding this comment.
If we had more cli flags, it would make sense to create a CliFlags struct and parse the flags in a separate function that would return the CliFlags struct. Considering we have just one flag other than the logtostderr this should be good.
ashish-amarnath
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ashish-amarnath
force-pushed
the
reconcile-single-ns
branch
from
015d209 to
27af2ff
Compare
detiber
reviewed
Feb 26, 2019
Contributor
|
/approve leaving lgtm to @vincepri |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashish-amarnath, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
ashish-amarnath
added a commit
to ashish-amarnath/cluster-api-provider-aws
that referenced
this pull request
Feb 27, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 27, 2019
* document the 'namespace' cli flag to capa controller #607 * fixes * Update docs/reconcile-in-custom-namespace.md Co-Authored-By: ashish-amarnath <ashish.amarnath@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cli flag to supply namespace for capa controller to watch for capi objects
What this PR does / why we need it:
This PR adds a CLI flag to restrict the namespace that capa controllers watch for capi objects to reconcile
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #581
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: