Skip to content

✨ add NestedVirtualization to CPUOptions in v1beta2 API - #5874

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
jhjaggars:feat/nested-virtualization
Apr 1, 2026
Merged

✨ add NestedVirtualization to CPUOptions in v1beta2 API#5874
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
jhjaggars:feat/nested-virtualization

Conversation

@jhjaggars

@jhjaggars jhjaggars commented Feb 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds NestedVirtualization field to CPUOptions in the v1beta2 AWSMachineSpec, allowing users to enable or disable nested virtualization on supported instance types (C8i, M8i, R8i). The field is wired through to the EC2 RunInstances call via CpuOptionsRequest.NestedVirtualization.

Round-tripping through v1beta1 is handled by the existing annotation-based restore pattern in awsmachine_conversion.go and awscluster_conversion.go — no v1beta1 type changes are needed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Requires github.com/aws/aws-sdk-go-v2/service/ec2 >= v1.288.0 for CpuOptionsRequest.NestedVirtualization support.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add NestedVirtualization field to CPUOptions in AWSMachineSpec (v1beta2), allowing users to enable or disable nested virtualization on supported instance types (C8i, M8i, R8i).

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2026
@k8s-ci-robot

k8s-ci-robot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Hi @jhjaggars. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2026
@jhjaggars jhjaggars mentioned this pull request Feb 23, 2026
Closed
3 tasks
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from 9c66fd4 to b8edaaf Compare February 23, 2026 23:36
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2026
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from b8edaaf to 30e0474 Compare February 26, 2026 15:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2026
@jhjaggars
jhjaggars marked this pull request as ready for review February 26, 2026 15:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from nrb February 26, 2026 15:28
@jhjaggars jhjaggars changed the title feat: add NestedVirtualization to CPUOptions in v1beta1 and v1beta2 APIs ✨ add NestedVirtualization to CPUOptions in v1beta1 and v1beta2 APIs Feb 26, 2026
@damdo

damdo commented Feb 28, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2026
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from 30e0474 to cc9cfa8 Compare March 6, 2026 15:05
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from cc9cfa8 to 40da886 Compare March 17, 2026 14:41
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 17, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jhjaggars / name: Jesse Jaggars (e227373)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2026
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from 40da886 to e722ab2 Compare March 17, 2026 14:55
@jhjaggars

jhjaggars commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

/easycla

@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from e722ab2 to 78e3606 Compare March 17, 2026 15:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 17, 2026
@jhjaggars

jhjaggars commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from 78e3606 to 8223cce Compare March 17, 2026 16:37
@jhjaggars
feat: add NestedVirtualization to CPUOptions in v1beta2 API
e227373 
Add NestedVirtualizationPolicy type and NestedVirtualization field to
CPUOptions in v1beta2. Wire it through to the EC2 RunInstances call.
Round-tripping through v1beta1 is handled by the existing annotation-based
restore pattern in awsmachine_conversion.go and awscluster_conversion.go.
@jhjaggars
jhjaggars force-pushed the feat/nested-virtualization branch from 8223cce to e227373 Compare March 17, 2026 17:00
@jhjaggars jhjaggars changed the title ✨ add NestedVirtualization to CPUOptions in v1beta1 and v1beta2 APIs ✨ add NestedVirtualization to CPUOptions in v1beta2 API Mar 17, 2026
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 17, 2026
@cam-from-ditto

cam-from-ditto commented Mar 20, 2026

Copy link
Copy Markdown

just ran into a problem this will solve, it would be great to get this merged

@damdo

damdo commented Mar 20, 2026

Copy link
Copy Markdown
Member

/assign @nrb

@nrb

nrb commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@richardcase

richardcase commented Apr 1, 2026

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2026
@k8s-ci-robot

k8s-ci-robot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 6cd14972ebe85dc294903bbdd9d64d2e85385257

@k8s-ci-robot
k8s-ci-robot merged commit d66d0b7 into kubernetes-sigs:main Apr 1, 2026
25 checks passed
@jhjaggars jhjaggars mentioned this pull request Jun 5, 2026
Merged
4 tasks
@justinmir justinmir mentioned this pull request Jul 22, 2026
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky
@richardcase richardcase Awaiting requested review from richardcase
@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@nrb nrb

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jhjaggars @k8s-ci-robot @damdo @cam-from-ditto @nrb @richardcase