Skip to content

Conversation

alexander-demicev
Copy link
Contributor

@alexander-demicev alexander-demicev commented Sep 10, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fix AWSManagedClusterTemplate short name. The current short name conflicts with CAPZ, making it impossible to install the latest CAPA version on the same management cluster as CAPZ.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

action required
The short name for AWSManagedClusterTemplate has changed from amct to awsmct. If you have any automation that relies on the short name it will needf to be updated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2025
@richardcase
Copy link
Member

/cherry-pick release-2.9

@k8s-infra-cherrypick-robot

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5cea11b8a66bc0d8fccdc3d54e8737eb1de743af

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, fun.

We should probably add an action required section about this in the release notes, warning the user that if they have any scripts or automation using this shortname they should update it.

I'd start the release-note comment with a single line at the top saying, and describe this

action required

@damdo
Copy link
Member

damdo commented Sep 10, 2025

/hold

For release note change

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2025
@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Sep 10, 2025

@richardcase @damdo hey,

When can we expect a new patch release including this fix? We are pretty much close to our deadlines and bumped CAPA recently to 2.9.0 which uses CAPI v1.10.x series, so definitely would like to keep supporting newer CAPI if possible (and that needs a new CAPA patch release with this changes) and avoids a downgrade on our side.

@richardcase
Copy link
Member

I can do the release tomorrow morning when the cherry pick merged

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@richardcase
Copy link
Member

/release-note-edit

action required
The short name for AWSManagedClusterTemplate has changed from amct to awsmct. If you have any automation that relies on the short name it will needf to be updated.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 10, 2025
@richardcase
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit d54ea9b into kubernetes-sigs:main Sep 10, 2025
27 checks passed
@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5663

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants