-
Notifications
You must be signed in to change notification settings - Fork 631
🐛 Fix AWSManagedClusterTemplate short name #5662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix AWSManagedClusterTemplate short name #5662
Conversation
Signed-off-by: Alexandr Demicev <[email protected]>
/cherry-pick release-2.9 |
@richardcase: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
LGTM label has been added. Git tree hash: 5cea11b8a66bc0d8fccdc3d54e8737eb1de743af
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, fun.
We should probably add an action required section about this in the release notes, warning the user that if they have any scripts or automation using this shortname they should update it.
I'd start the release-note comment with a single line at the top saying, and describe this
action required
/hold For release note change |
@richardcase @damdo hey, When can we expect a new patch release including this fix? We are pretty much close to our deadlines and bumped CAPA recently to 2.9.0 which uses CAPI v1.10.x series, so definitely would like to keep supporting newer CAPI if possible (and that needs a new CAPA patch release with this changes) and avoids a downgrade on our side. |
I can do the release tomorrow morning when the cherry pick merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/release-note-edit
|
/unhold |
@richardcase: new pull request created: #5663 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix AWSManagedClusterTemplate short name. The current short name conflicts with CAPZ, making it impossible to install the latest CAPA version on the same management cluster as CAPZ.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: