Skip to content

🐛 Add validation to prevent Spot instances with CapacityReservationsOnly preference #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

🐛 Add validation to prevent Spot instances with CapacityReservationsOnly preference #5633

merged 1 commit into from
Aug 28, 2025

Conversation

BraeTroutman
Copy link
Contributor

@BraeTroutman BraeTroutman commented Aug 27, 2025 •
edited by damdo
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adds webhook validation to block conflicting configuration where CapacityReservationPreference is set to 'CapacityReservationsOnly' while MarketType is 'Spot' (or SpotMarketOptions is set), as this combination is not supported by AWS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes OCPBUGS-60943

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

fix: disallow setting of `CapacityReservationPreference: CapacityReservationsOnly` when `MarketType: Spot` or `SpotMarketOptions` is set

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 27, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from nrb August 27, 2025 16:21
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BraeTroutman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2025
@damdo
Copy link
Member

damdo commented Aug 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2025
damdo
damdo reviewed Aug 28, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix @BraeTroutman

I left a couple of thoughts, but mostly LGTM

damdo
damdo reviewed Aug 28, 2025
View reviewed changes
@BraeTroutman
Add validation to prevent Spot instances with capacity-reservations-o…
fa170d4 
…nly preference

Adds webhook validation to block conflicting configuration where
CapacityReservationPreference is set to 'capacity-reservations-only'
while MarketType is 'Spot', as this combination is not supported by AWS.
damdo
damdo reviewed Aug 28, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks a lot for addressing my comments!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf45d29f43368ca018e761dac95ff7c53e155827

@damdo damdo changed the title 🐛 Add validation to prevent Spot instances with capacity-reservations-only preference 🐛 Add validation to prevent Spot instances with CapacityReservationsOnly preference Aug 28, 2025
@nrb
Copy link
Contributor

nrb commented Aug 28, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit dcfaef0 into kubernetes-sigs:main Aug 28, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@nrb nrb Awaiting requested review from nrb

Assignees

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BraeTroutman @k8s-ci-robot @damdo @nrb