-
Notifications
You must be signed in to change notification settings - Fork 631
🌱Migrate instancestate to AWS SDK v2 #5562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱Migrate instancestate to AWS SDK v2 #5562
Conversation
Hi @phuhung273. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/test pull-cluster-api-provider-aws-test |
Hey @phuhung273 thanks a lot for your PR! Judging from https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5562/pull-cluster-api-provider-aws-verify/1937034209499549696 It looks like:
Would you be able to see to that? Thanks! |
894e14c
to
7c72605
Compare
Sure @damdo thanks for taking a look, CI is good now. |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
/assign @richardcase @nrb @AndiDog @dlipovetsky For an approver review |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
Please let me know if I should I fix the 2 failing tests @damdo |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 07116142805c9b8192aeb5c0ab397992897b63fd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
This PR migrates instancestate to AWS SDK V2
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5408
Special notes for your reviewer:
Checklist:
Release note: