Skip to content

Conversation

phuhung273
Copy link
Contributor

What type of PR is this?
/kind cleanup
/kind deprecation

What this PR does / why we need it:
This PR migrates instancestate to AWS SDK V2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5408

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Migrate instancestate code to AWS SDK v2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @phuhung273. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Jun 23, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2025
@damdo
Copy link
Member

damdo commented Jun 23, 2025

/test pull-cluster-api-provider-aws-test

@damdo
Copy link
Member

damdo commented Jun 23, 2025

Hey @phuhung273 thanks a lot for your PR!

Judging from https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5562/pull-cluster-api-provider-aws-verify/1937034209499549696 It looks like:

  1. Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/helpers/kubernetesversions/template.go Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/util/defaulting/defaulting.go Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/util/defaulting/doc.go Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/util/paused/paused.go Boilerplate header is wrong for: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/util/paused/paused_test.go make: [Makefile:329: verify-boilerplate] Error 1 (ignored)
  2. And go mod tidy is a little off and needs to be rerun

Would you be able to see to that? Thanks!

@phuhung273 phuhung273 force-pushed the instancestate-sdk-v2 branch from 894e14c to 7c72605 Compare June 23, 2025 12:41
@phuhung273
Copy link
Contributor Author

Sure @damdo thanks for taking a look, CI is good now.

@damdo
Copy link
Member

damdo commented Jun 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member

damdo commented Jun 24, 2025

/assign @richardcase @nrb @AndiDog @dlipovetsky

For an approver review

@damdo
Copy link
Member

damdo commented Jun 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e

@phuhung273
Copy link
Contributor Author

Please let me know if I should I fix the 2 failing tests @damdo

@damdo
Copy link
Member

damdo commented Jun 24, 2025

/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e

@phuhung273
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @phuhung273

/lgtm

/assign @nrb @richardcase @AndiDog @dlipovetsky

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07116142805c9b8192aeb5c0ab397992897b63fd

Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 570bb5e into kubernetes-sigs:main Jun 25, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Jun 25, 2025
@phuhung273 phuhung273 deleted the instancestate-sdk-v2 branch June 25, 2025 23:08
@phuhung273 phuhung273 mentioned this pull request Jul 1, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate instancestate code to AWS SDK v2

7 participants