-
Notifications
You must be signed in to change notification settings - Fork 629
🐛 fix: missing MaxActiveUpdateDeleteWait in managednodegroup scope #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: missing MaxActiveUpdateDeleteWait in managednodegroup scope #5554
Conversation
/test pull-cluster-api-provider-aws-e2e-eks |
/release-note-none |
/test pull-cluster-api-provider-aws-e2e-eks |
Feel free to unhold when the e2e pass: /hold |
Thanks for this @damdo /lgtm |
LGTM label has been added. Git tree hash: f51d046118b27872a8e1f1e15fd5dde97ba48baa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests passed 🎉 /unhold |
/cherrypick release-2.8 |
@dlipovetsky: #5554 failed to apply on top of branch "release-2.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dlipovetsky IIUC #5498 which introduced this is only in main and not in any v2.8.z or in release-2.8 |
I'm sorry--not what I wanted to do. I wanted to backport #5517 to release-2.8 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
#5498 missed propagating the MaxActiveUpdateDeleteWait to the managednodegroup scope, resulting in a zero value which made the wait fail, which in turn always failed the E2E.
Which issue(s) this PR fixes:
Fixes #5514