Skip to content

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Jun 4, 2025

What type of PR is this?

#5497 introduced this bug (copy-paste mistake) which leads to permanent updates of the ASG like this:

capa_control… │ I0604 10:14:12.938231      13 awsmachinepool_controller.go:528] "asg diff detected" controller="awsmachinepool" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSMachinePool" AWSMachinePool="org-myorg/andreas245-mp-0" namespace="org-myorg" name="andreas245-mp-0" reconcileID="5480a2f8-f0b3-44c5-af31-0c74cbe7bce3" machinePool="org-myorg/andreas245-mp-0" cluster="org-myorg/andreas245" asgDiff=<
capa_control… │ 	Ā Ā v1beta2.AWSMachinePoolSpec{
capa_control… │ 	Ā Ā 	ProviderID:        "arn:aws:autoscaling:eu-west-2:242036376510:autoScalingGroup:6e23"...,
capa_control… │ 	-Ā 	MinSize:           1,
capa_control… │ 	+Ā 	MinSize:           10,
capa_control… │ 	Ā Ā 	MaxSize:           10,
capa_control… │ 	Ā Ā 	AvailabilityZones: {"eu-west-2a"},
capa_control… │ 	Ā Ā 	... // 13 identical fields
capa_control… │ 	Ā Ā }
capa_control… │  > subnetDiff=""

/kind bug

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix determined value for `MinSize` field of ASG, avoiding unnecessary updates to ASG

@AndiDog AndiDog requested a review from alexander-demicev June 4, 2025 10:22
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2025
@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fa0787efc58c7b404d594eb94c3801ffe4ac5ad

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4a657f8 into kubernetes-sigs:main Jun 4, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants